Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata: Ignore date string defaults caused by software errors #3229

Closed
lastzero opened this issue Feb 24, 2023 · 8 comments
Closed

Metadata: Ignore date string defaults caused by software errors #3229

lastzero opened this issue Feb 24, 2023 · 8 comments
Assignees
Labels
enhancement Refactoring, improvement or maintenance task metadata Related to Exif, XMP, IPTC & Co. released Available in the stable release

Comments

@lastzero
Copy link
Member

lastzero commented Feb 24, 2023

As a user of a camera or phone with a software bug, I want PhotoPrism to ignore the date information that it writes to metadata so that my pictures don't have the wrong date or time.

The following date strings should be ignored in metadata:

  • 0000-00-00
  • 0000-00-00 00:00:00
  • 0000:00:00 00:00:00
  • 0001-01-01 00:00:00
  • 0001:01:01 00:00:00
  • 0001-01-01 00:00:00 +0000 UTC
  • 1970-01-01
  • 1970-01-01 00:00:00
  • 1970:01:01 00:00:00
  • 1980-01-01
  • 1980-01-01 00:00:00
  • 1980:01:01 00:00:00
  • 2002-12-08 12:00:00
  • 2002:12:08 12:00:00
  • and similar
@lastzero lastzero self-assigned this Feb 24, 2023
@lastzero lastzero added enhancement Refactoring, improvement or maintenance task metadata Related to Exif, XMP, IPTC & Co. labels Feb 24, 2023
lastzero added a commit that referenced this issue Feb 24, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero
Copy link
Member Author

@reidprichard You are invited to test these changes! A new development preview build will be available soon:

@lastzero lastzero added the please-test Ready for acceptance test label Feb 24, 2023
lastzero added a commit that referenced this issue Feb 24, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero added a commit that referenced this issue Feb 24, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
@reidprichard
Copy link

This did the trick! After re-indexing my library I have zero pictures in my "December 2002" folder, whereas I previously had several hundred.

Thank you, @lastzero!

@lastzero lastzero added tested Changes have been tested successfully and removed please-test Ready for acceptance test labels Feb 28, 2023
seeschloss pushed a commit to seeschloss/photoprism that referenced this issue Apr 10, 2023
seeschloss pushed a commit to seeschloss/photoprism that referenced this issue Apr 10, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
seeschloss pushed a commit to seeschloss/photoprism that referenced this issue Apr 10, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
@GlassedSilver
Copy link

How are false positives avoided? What if I took a shot exactly at midnight on December 8, 2002?

@lastzero
Copy link
Member Author

Unlikely.

@graciousgrey graciousgrey added released Available in the stable release and removed tested Changes have been tested successfully labels May 3, 2023
@GlassedSilver
Copy link

Unlikely, but not impossible, maybe making this optional or only trigger when there are multiple shots for the exact same time that's sharp midnight might make sense.

If you have a million users unlikely turns into likely to affect a few thousands over time possibly.

@lastzero
Copy link
Member Author

lastzero commented May 3, 2023

If you have such an image, please share it with us.

@GlassedSilver
Copy link

What if I don't, but people who aren't aware of this new app behavior do, and they scratch their head wondering why they can't find a given image just because they got unlucky by shooting at a too "perfect moment", e.g. at midnight at someone's birthday party?

Is my feedback only valid if it affects me or are you trying to find forensic differences between legit and false midnight shots? Doubt there's much to get, but maybe I'm wrong. (legitimately curious btw)

@lastzero
Copy link
Member Author

lastzero commented May 3, 2023

It can happen, but much much more often it happens that the date is invalid. It's a tradeoff and only affects a single second. So not a lot of pictures as if it were a full day. Probability is on our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Refactoring, improvement or maintenance task metadata Related to Exif, XMP, IPTC & Co. released Available in the stable release
Projects
Status: Release 🌈
Development

No branches or pull requests

4 participants