-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config: Title of the search page must be set based on the site title #3439
Comments
While I recognize that there is room for improvement, this seems to work more or less as intended. Could you additionally try setting |
I tried |
Yeah, so it is possible that overwriting the title with In the short term, you can also achieve the behavior by adding a line or two of Go if you are comfortable with building from source. |
Signed-off-by: Michael Mayer <michael@photoprism.app>
@edwinclement08 Thanks to your report, I found a line in our frontend code that should not be there and caused a different behavior in our community edition. I apologize for that. After removing this line, I tested it again. For this I started the server as follows (of course you can use environment variables instead):
To verify the effect of the config values, I've then used this command, which confirms that the site title was applied to the app name:
If a site-caption is set, it will be used as page title on the (default) search page: Otherwise, and on all other pages, the configured site title will be used: I would appreciate if you could test it again with this change. An updated development preview build will be available soon! |
The release notes have been updated to mention this issue: https://docs.photoprism.app/release-notes/#development-preview These docs explain how to use our preview build: https://docs.photoprism.app/getting-started/updates/#development-preview |
Hey @lastzero, thanks for your quick fix. Updating Caption and Title to the same value resolved the issue. |
Thank you very much for testing! We will try to release a new stable version with this fix in the next few days. In the meantime, our development preview is generally safe to use, as it does not contain any breaking changes or known issues. |
Thanks a lot😄. |
1. What is not working as documented?
When setting the PHOTOPRISM_SITE_TITLE environmental variable via PHOTOPRISM_SITE_TITLE, the search page still shows 'Photoprism'.
The other pages like Albums and Favourites show the ' - ' as expected.
2. How can we reproduce it?
Steps to reproduce the behavior:
Run the docker container with PHOTOPRISM_SITE_TITLE env variable set to anything other than Photoprism
3. What behavior do you expect?
The Title of the page to be when on home page
4. What could be the cause of your problem?
Not sure
5. Can you provide us with example files for testing, error logs, or screenshots?
6. Which software versions do you use?
(a) PhotoPrism Architecture & Build Number: PhotoPrism® CE Build [230514-0b780defb]
(b) Database Type & Version: SQLite
(c) Operating System Types & Versions: Windows
(d) Browser Types & Versions: Firefox, Chrome
(e) Ad Blockers, Browser Plugins, and/or Firewall Software?
No
7. On what kind of device is PhotoPrism installed?
Unraid
(a) Device / Processor Type:
Intel Core i7-3770
(b) Physical Memory & Swap Space in GB
16 GB, 1 GB
(c) Storage Type: HDD
(d) Anything else that might be helpful to know?
Did try to edit options.yml and got the same result.
8. Do you use a Reverse Proxy, Firewall, VPN, or CDN?
No
The text was updated successfully, but these errors were encountered: