Config: Skip the creation of a default HTTPS certificate if PHOTOPRISM_DEFAULT_TLS is "false"

[lastzero]

Discussed in #3819

^{Originally posted by barry-luijten October 12, 2023}
Hi,

I have just upgraded Photoprism to the latest version (231011) and I noticed these logs during startup of the container, while I explicitly set the environment variables PHOTOPRISM_DISABLE_TLS="true" and PHOTOPRISM_DEFAULT_TLS="false":

started 231011 as root (amd64-prod)
init: https
Creating a default HTTPS/TLS certificate.
Generating self-signed issuer (CA) certificate...
Generating self-signed tls certificate...
Certificate request self-signature ok
subject=C = DE, ST = Berlin, L = Berlin, O = PhotoPrism, OU = Self-Hosted, emailAddress = hello@photoprism.app, CN = PhotoPrism
Updating permissions of keys in '/etc/ssl/private'...
Running 'update-ca-certificates'...
Updating certificates in /etc/ssl/certs...
mv: cannot move '/etc/ssl/certs/ca-certificates.crt.new' to 'ca-certificates.crt': Device or resource busy
make: *** [Makefile:16: install-https] Error 1

The error message is caused by the fact that I am mounting my own ca-certificates from a Docker config, so it's read-only in the container. I just think it is strange that Photoprism seems to be generating a self-signed CA and certificate while I configured it not to to anything with TLS. Photoprism seems to be working fine, but it looks like the environment variables have no effect on this behavior.
FYI, I'm using Traefik Proxy for handling https certificates, so no need for them in the container.

Please let me know if I'm doing anything wrong here ;)

[lastzero]

This can be tested with our next preview build, which will be available in the next few days, probably on Sunday or Monday.

[lastzero]

An updated preview build is now available for testing:

• https://docs.photoprism.app/getting-started/updates/#development-preview

[lastzero]

If we don't get any more feedback/problem reports regarding this issue, I'll consider the improvements ready for release :)