New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JPEG: Fix decoding of images with invalid color metadata #3843
Comments
Might be caused by the GPS position data, which probably makes our parser throw an error. |
I still get the error even if I remove all GPS data from the file. |
Might still be cached in the json file unless you tested it on a new instance with no existing files? |
The instance was reset and the sidecar folder was deleted. |
lastzero
changed the title
Metadata: Repair broken files
JPEG: Explicitly read files with invalid color metadata from the beginning to avoid decoding errors
Oct 31, 2023
lastzero
changed the title
JPEG: Explicitly read files with invalid color metadata from the beginning to avoid decoding errors
JPEG: Read files with invalid color data from the beginning
Oct 31, 2023
lastzero
added a commit
that referenced
this issue
Oct 31, 2023
Using a ReadSeeker is necessary to read images with invalid color metadata from the beginning in order to avoid decoding errors. Signed-off-by: Michael Mayer <michael@photoprism.app>
An updated preview build will be available for testing soon: |
lastzero
added
please-test
Ready for acceptance test
bug
Something isn't working
and removed
enhancement
Optimization, improvement or maintenance task
labels
Oct 31, 2023
lastzero
changed the title
JPEG: Read files with invalid color data from the beginning
JPEG: Files with invalid color metadata must be decoded from the beginning
Oct 31, 2023
lastzero
changed the title
JPEG: Files with invalid color metadata must be decoded from the beginning
JPEG: Fix decoding of images with invalid color metadata
Oct 31, 2023
lastzero
added a commit
that referenced
this issue
Nov 9, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
graciousgrey
added
tested
Changes have been tested successfully
and removed
please-test
Ready for acceptance test
labels
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The mentioned file below can only be indexed if the exif metadata is removed. The mime type matches the file extension.
Acceptance Criteria:
Discussed in #3782
Originally posted by picklerick323 October 3, 2023
I have been getting this error in a couple of photos that I upload. I've attached a photo that gives me the error.
thumb: unrecognised image format in 20231001_134923_0D85D20D.jpg (read color metadata)
2023-10-02 16:31:25
index: failed creating thumbnails for 2023/10/20231001_134923_0D85D20D.jpg (image: unknown format while decoding)
2023-10-02 16:31:25
The text was updated successfully, but these errors were encountered: