-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker size #39
Comments
Yes, great idea. I guess we can remove lots of stuff from the development image related to TensorFlow and Python. It's there to experiment, but most of it is not used. But of course we need the TensorFlow model, HTML templates, JS & CSS code etc, so just a single binary is not enough. Do you think it would work without any TensorFlow libs installed? I don't think so, but never tried. |
I don't know a thing about Photoprism, I just saw the project on github explore and wanted to gave a shot via docker. And I don't know a thing about Tensorflow either. So, on a pure docker based point of view
|
I see. We use Tensorflow as a library for image classification. Doing this via rest means copying the contents (that are already in memory) to a different container via HTTP just to get some tag labels back. Can be done, but probably not very efficient. Also means maintaining another app as a server. There are (commercial) ready-to-use tensorflow based container images available for that though. Maybe worth an experiment if there is time. Not sure how small they are. Our image certainly has to become smaller. Contains lots of dev only stuff right now. |
Working on this right now... There will be a development base image and one for production without any dev / build tools. |
Compressed size is 172 MB now. Build and push to Docker Hub performed by Travis CI whenever develop is merged into master. |
Purrrfect, thanks ! |
Hi
I was wondering why downloading photoprism container took so much time...
May I suggest a multistage build ? Here's the doc https://docs.docker.com/develop/develop-images/multistage-build/
Basically, if you can make a standalone photoprism binary (aka no need for local third party)
The text was updated successfully, but these errors were encountered: