New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebDAV: Preserve file modification timestamps #3959
Comments
Note that this is still experimental and the implementation needs to be tested with a WebDAV client that sends a valid "X-OC-MTime" header. Signed-off-by: Michael Mayer <michael@photoprism.app>
Signed-off-by: Michael Mayer <michael@photoprism.app>
Signed-off-by: Michael Mayer <michael@photoprism.app>
The Note that this is a custom, non-standard header and therefore only works when WebDAV clients like PhotoSync submit this header along with the uploaded file. We would therefore appreciate if you could help us test these changes and provide feedback on them (by using the test image) before we make them available to everyone in the upcoming release. Edit: If the WebDAV client/app you are using does not submit the file modification date, there is not much we can do. However, it should be easy for app developers to add it if you ask them to. Thank you! |
@lastzero Please build arm64 image! I tried to pull test version and deploy docker, got error:
|
First tests showed that the modification date could not be preserved when syncing using PhotoSync or Apples finder. There may be special settings needed or they do not support the header. |
Since the time we can spend on this is quite limited due to the many other issues that also need attention, we would appreciate help with testing and finding out which WebDAV clients support this or another timestamp request header. Thank you very much! 🙏 |
Thanks for adding the timestamp support! This is not only useful during import, but also when the originals are managed via webdav. Rclone is able to set the file timestamp in the current photoprism test version. Verified by
|
FolderSync is able to set the file timestamp in the current photoprism test version. Verified by:
|
As a user I want the built in webdavserver to preserve timestamps, so that the file modification date is not changed when files get synced using webdav.
Acceptance Criteria:
Discussed in #2550
Originally posted by atvking July 26, 2022
I'm running PhotoPrism in a docker container on an UnRaid server and it doesn't seem to matter what client I use (FolderSync Pro, PhotoSync, Windows File Explorer, etc.) to upload to the Originals folder, the modification date of the file is always changed to the date/time of upload rather than the date/time the photo was taken. Is there some way to avoid this?
Uploading the same files using the same clients to a folder in Nextcloud via its WebDAV server doesn't have the same issue.
I'm trying to avoid uploading to a Nextcloud folder via Nextclouds WebDAV and setting my Originals folder to use that folder because then I would have to schedule a cron job (or something) to index the files, whereas they are indexed automatically when using Photoprisms WebDAV.
I have already tried setting the PHOTOPRISM_DISABLE_CHOWN flag but I didn't have much hope that it would work anyway because the folder ownership and permissions are identical between the Originals folder on my PhotoPrism share and the Nextcloud folder I am syncing the same files to (as a test) on my Nextcloud share and do not change after uploading a file.
Suggestions?
The text was updated successfully, but these errors were encountered: