Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata: Files with an invalid F-number fail to index #4170

Closed
graciousgrey opened this issue Apr 11, 2024 · 2 comments
Closed

Metadata: Files with an invalid F-number fail to index #4170

graciousgrey opened this issue Apr 11, 2024 · 2 comments
Assignees
Labels
bug Something isn't working metadata Related to Exif, XMP, IPTC & Co. tested Changes have been tested successfully

Comments

@graciousgrey
Copy link
Member

As a user with files that have an invalid F-number in their Exif data, I want PhotoPrism to index the files anyway.

It seems that some old samsung phones generate invalid Fnumbers, e.g. "EXIF:FNumber": "2.8 1". Those files cannot be indexed at this time. level=trace msg="photo: Error 1264: Out of range value for column 'photo_f_number' at row 1 in filename.jpg (create)"

Acceptance Criteria:

  • Files with an invalid FNumber MUST be indexed
@graciousgrey graciousgrey added the enhancement Optimization, improvement or maintenance task label Apr 11, 2024
@lastzero lastzero changed the title Index: Index files with invalid fnumber Metadata: Files with an invalid F-number fail to index Apr 11, 2024
@lastzero lastzero added metadata Related to Exif, XMP, IPTC & Co. bug Something isn't working and removed enhancement Optimization, improvement or maintenance task labels Apr 11, 2024
@thanasisn
Copy link

Hello, thank you for addressing the issue.

Although, I created a way to edit those files, and correct the problematic tags. In case someone wants to fix the original metadata.

First, I created a generalized script to list all images with a specific tag (here the model of the phone):
exif_list_by_tag_value.sh

exif_list_by_tag.sh "exif:Model" "GT-B2710" "./path/to/folder" > ./files_with_tag.list

and then a script to edit all the offending FNumber tags with: exif_edit_tag.sh

cat ./files_with_tag.list | xargs -P 4 -I % exif_edit_tag.sh % 

After this, my pictures were indexed by photoprism, without any problem.

lastzero added a commit that referenced this issue Apr 12, 2024
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero lastzero added the please-test Ready for acceptance test label Apr 12, 2024
@lastzero
Copy link
Member

An updated preview build is now available on Docker Hub for you to test these changes:

Any help with that is much appreciated! 🎉

@graciousgrey graciousgrey added tested Changes have been tested successfully and removed please-test Ready for acceptance test labels Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working metadata Related to Exif, XMP, IPTC & Co. tested Changes have been tested successfully
Projects
Status: Release 🌈
Development

No branches or pull requests

3 participants