Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uploads: Do not display negative ETA in Web upload dialog #4285

Closed
lastzero opened this issue May 21, 2024 · 0 comments
Closed

Uploads: Do not display negative ETA in Web upload dialog #4285

lastzero opened this issue May 21, 2024 · 0 comments
Assignees
@graciousgrey
Labels
bug Something isn't working released Available in the stable release ux Impacts User Experience

Comments

@lastzero
Copy link
Member

This can happen e.g. because of rounding errors, so that the remaining upload time is displayed as -0 seconds. To fix this, we should only display the time if it is positive.
@lastzero lastzero added bug Something isn't working ux Impacts User Experience labels May 21, 2024
@lastzero lastzero self-assigned this May 21, 2024
lastzero added a commit that referenced this issue May 21, 2024
@lastzero
UX: Do not display negative ETA in Web upload dialog #4285
885a42f 
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero lastzero changed the title UX: Web upload dialog may display negative ETA for a brief moment Upload: Do not display negative ETA in Web upload dialog May 21, 2024
@lastzero lastzero added the please-test Ready for acceptance test label May 21, 2024
@lastzero lastzero assigned graciousgrey and unassigned lastzero May 21, 2024
@lastzero lastzero changed the title Upload: Do not display negative ETA in Web upload dialog Uploads: Do not display negative ETA in Web upload dialog May 21, 2024
@graciousgrey graciousgrey added tested Changes have been tested successfully released Available in the stable release and removed please-test Ready for acceptance test tested Changes have been tested successfully labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@graciousgrey graciousgrey

Labels
bug Something isn't working released Available in the stable release ux Impacts User Experience
Projects
Roadmap 🚀✨
Status: Release 🌈
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lastzero @graciousgrey