Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage #58

Closed
2 of 3 tasks
lastzero opened this issue Nov 6, 2018 · 3 comments
Closed
2 of 3 tasks

Improve test coverage #58

lastzero opened this issue Nov 6, 2018 · 3 comments
Assignees
@lastzero @graciousgrey
Labels
released Available in the stable release
Projects
Development
Milestone
MVP

Comments

@lastzero
Copy link
Member

lastzero commented Nov 6, 2018 •
edited

As a developer, I want increased unit test coverage to have a smoother development experience and greater confidence.

Acceptance Criteria:

  • Public code coverage / code quality report
  • Each package must have tests covering 90% of the code
  • All tests should run in less than 10 minutes, ideally 5 minutes or less (conversion of RAW images can take some time...)
@lastzero lastzero added the enhancement Optimization, improvement or maintenance task label Nov 6, 2018
@lastzero lastzero added this to the MVP milestone Nov 6, 2018
@lastzero lastzero self-assigned this Nov 6, 2018
lastzero added a commit that referenced this issue Nov 6, 2018
@lastzero
Added test-coverage to Makefile and upload to codecov, see #58
a3167cc
lastzero added a commit that referenced this issue Nov 6, 2018
@lastzero
Add codecov badge and remove -race from test-coverage target #58
64371e4
lastzero added a commit that referenced this issue Nov 6, 2018
@lastzero
Add codecov.yml #58
ebaa3d3
lastzero added a commit that referenced this issue Nov 6, 2018
@lastzero
Add test-codecov to Makefile and travis.yml #58
810d8a7
lastzero added a commit that referenced this issue Nov 6, 2018
@lastzero
Fix for passing CODECOV_TOKEN to container #58
7f977e2
lastzero added a commit that referenced this issue Nov 6, 2018
@lastzero
Set CODECOV_TOKEN env in docker-compose #58
9e8ed74
lastzero added a commit that referenced this issue Nov 6, 2018
@lastzero
Add codecov.sh script #58
af828ef
lastzero added a commit that referenced this issue Nov 6, 2018
@lastzero
Try to speed up building by removing python and full tensorflow #58
56b9eeb
lastzero added a commit that referenced this issue Nov 6, 2018
@lastzero
Fix docker-compose.travis.yml (remove duplicate env token) #58
1809868
lastzero added a commit that referenced this issue Nov 9, 2018
@lastzero
Attempt reduce build / test times with travis cache #58
18f88b8
lastzero added a commit that referenced this issue Nov 9, 2018
@lastzero
Remove debug information and dot files from production build #58
9001075
lastzero added a commit that referenced this issue Nov 9, 2018
@lastzero
Add before_cache to fix travis caching #58
dc00809
lastzero added a commit that referenced this issue Nov 9, 2018
@lastzero
Don't build in Dockerfile #58
1f69530 
Caching of dependencies is not possible otherwise
lastzero added a commit that referenced this issue Nov 9, 2018
@lastzero
Fixed default value for database DSN #58
90d73e4
@lastzero
Copy link
Member Author

lastzero commented Nov 9, 2018

Build / test time on Travis CI was reduced to ~ 5 minutes. It makes sense to split unit (core functionality) and acceptance tests (with many different photos and sidecar files) for further improvements.

@lastzero lastzero added the in-progress Somebody is working on this label Nov 9, 2018
@lastzero lastzero mentioned this issue Nov 9, 2018
Closed
8 tasks
lastzero added a commit that referenced this issue Nov 15, 2018
@lastzero
Move slow tests to *_slow_test.go #58
8063ba3 
- Added a new make target: test-fast
- To execute all test, you have to use -tags=slow
lastzero added a commit that referenced this issue Nov 15, 2018
@lastzero
Simplified Makefile #58
08caccd 
- Hopefully easier to understand for new developers
lastzero added a commit that referenced this issue Nov 15, 2018
@lastzero
Reduce timeout for "make test-fast" to 5m #58
b9fedb8
lastzero added a commit that referenced this issue Nov 17, 2018
@lastzero
Move utils and test config to separate packages #58
fb91ce9
lastzero added a commit that referenced this issue Nov 17, 2018
@lastzero
Fix slow tests and improve test output (colorized) #58
f7404f8
lastzero added a commit that referenced this issue Nov 17, 2018
@lastzero
Add test stubs and helper functions for package api #58
cdf9d92
lastzero added a commit that referenced this issue Nov 17, 2018
@lastzero
Expected status for like and dislike is accepted (202) #58
bb36226
lastzero added a commit that referenced this issue Nov 17, 2018
@lastzero
Run "make fmt" #58
86a6dda
lastzero added a commit that referenced this issue Nov 17, 2018
@lastzero
Add ConfigCommand test #58
9872cfa 
- Includes refactoring of existing packages to enable testing of commands
lastzero added a commit that referenced this issue Nov 18, 2018
@lastzero
Code clean-up #58
2e746c8
@lastzero lastzero added epic and removed enhancement Optimization, improvement or maintenance task labels Nov 22, 2018
@lastzero
Copy link
Member Author

Still at 54% - anyone is most welcome to help with this 👍

lastzero added a commit that referenced this issue Jun 30, 2019
@lastzero
Use daemon server mode to run acceptance tests #58
3655ebf
@lastzero
Copy link
Member Author

lastzero commented Jan 6, 2020

Not reached our % goal, but we take care of it day by day. Closing this.

@lastzero lastzero closed this as completed Jan 6, 2020
@lastzero lastzero added released Available in the stable release and removed in-progress Somebody is working on this labels Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lastzero lastzero

@graciousgrey graciousgrey

Labels
released Available in the stable release
Projects
No open projects
Development
  
Awaiting triage
Milestone
MVP
Development

No branches or pull requests
2 participants
@lastzero @graciousgrey