Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels: Show photo count #584

Closed
danielo515 opened this issue Nov 6, 2020 · 5 comments
Closed

Labels: Show photo count #584

danielo515 opened this issue Nov 6, 2020 · 5 comments
Assignees
Labels
idea Feedback wanted / feature request released Available in the stable release

Comments

@danielo515
Copy link

Hello.
Right now, I have a lot of labels, but very few photos per label.
It will be awesome if, before opening a label, I can see a count of how many images belong to it, so I get an idea if opening it is worth or not. Specially when the count it's 1, it's pointless to open such a label to see something you are already seeing.

Regards

@lastzero
Copy link
Member

lastzero commented Nov 8, 2020

Our API returns the count in the PhotoCount field, we just haven't found a nice way to display it yet:

Screenshot from 2020-11-08 17-31-38

@lastzero lastzero added the idea Feedback wanted / feature request label Nov 8, 2020
@danielo515
Copy link
Author

This is how they do on QuMagie (some inspiration)
image

@graciousgrey graciousgrey changed the title Show label count Labels / Show photo count Nov 26, 2020
@graciousgrey graciousgrey changed the title Labels / Show photo count Labels: Show photo count Jan 5, 2021
@hartraft
Copy link

hartraft commented Jul 23, 2021

I think the photocount would be nice to have as well. What would be a better preference?
Option 1: (similar to how albums are shown and translated but more verbose)
Photoprism-option1

Option 2: (plain and simple number)
Photoprism-option2

@lastzero
Copy link
Member

Note that label photo counts are currently not updated in real time:

https://github.com/photoprism/photoprism/blob/develop/internal/entity/photo_counts.go#L89

We had been using (automatically updated) views previously, but they were not compatible with all supported databases.

At the moment, counts can be reliably used to hide labels without any result. Counts > 1 may be imprecise at times e.g. while indexing. It may well lead to frustrated users filing bug reports because numbers don't match. Frequently happens for other counts as well. It's understandable as users are afraid of data loss, and bugs in general.

lastzero added a commit that referenced this issue Sep 17, 2021
@lastzero lastzero self-assigned this Sep 17, 2021
@lastzero lastzero added please-test Ready for acceptance test and removed unfunded labels Sep 17, 2021
@fensminger
Copy link

I updated photoprism to last preview. It is working.
image

@graciousgrey graciousgrey added released Available in the stable release and removed please-test Ready for acceptance test labels Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea Feedback wanted / feature request released Available in the stable release
Projects
Status: Release 🌈
Development

No branches or pull requests

5 participants