Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if we can (statically?) link against darktable using cgo #62

Closed
lastzero opened this issue Nov 9, 2018 · 1 comment
Closed

Check if we can (statically?) link against darktable using cgo #62

lastzero opened this issue Nov 9, 2018 · 1 comment
Assignees
@lastzero
Labels
declined Cannot be merged / implemented at this time enhancement Refactoring, improvement or maintenance task
Milestone
MVP

Comments

@lastzero
Copy link
Member

lastzero commented Nov 9, 2018

See darktable mailing list: https://www.mail-archive.com/darktable-dev@lists.darktable.org/msg03601.html

We use darktable-cli to convert RAW files to JPEG:
https://github.com/photoprism/photoprism/blob/develop/internal/photoprism/converter.go#L87
While this works, it would be amazing if we could (statically?) link
against darktable using cgo. I'm wondering if anyone has experience
with that or if you recommend to continue using darktable-cli?
@lastzero lastzero added help wanted Well suited for external contributors! enhancement Refactoring, improvement or maintenance task in-progress Somebody is working on this labels Nov 9, 2018
@lastzero lastzero self-assigned this Nov 9, 2018
@lastzero
Copy link
Member Author

Yes, we can, but it seems like too much work for now plus cgo has some disadvantages, see https://github.com/photoprism/photoprism/wiki/Converting-RAW-to-JPEG

lastzero added a commit that referenced this issue Nov 12, 2018
@lastzero
Add darktable development docker image #62
c5ee0fe 
- Improved build scripts and Dockerfile
- broadwayd can be used as display server for darktable or other GTK based software
lastzero added a commit that referenced this issue Nov 12, 2018
@lastzero
Move docker-compose.yml to /docker/photoprism for consistency #62
edc7c2f
lastzero added a commit that referenced this issue Nov 12, 2018
@lastzero
Prefix for build script variables #62
ef4f9c3
lastzero added a commit that referenced this issue Nov 12, 2018
@lastzero
Add scripts/travis.sh and remove IFs from .travis.yml #62
aa831d3
@lastzero lastzero removed in-progress Somebody is working on this help wanted Well suited for external contributors! labels Nov 12, 2018
@lastzero lastzero added this to the MVP milestone Nov 12, 2018
@lastzero lastzero added the declined Cannot be merged / implemented at this time label Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lastzero lastzero

Labels
declined Cannot be merged / implemented at this time enhancement Refactoring, improvement or maintenance task
Projects
None yet
Milestone
MVP
Development

No branches or pull requests
1 participant
@lastzero