Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Albums: Broken share expiration date in form label #621

Closed
Engr-AllanG opened this issue Nov 17, 2020 · 9 comments
Closed

Albums: Broken share expiration date in form label #621

Engr-AllanG opened this issue Nov 17, 2020 · 9 comments
Assignees
Labels
bug Something isn't working released Available in the stable release
Milestone

Comments

@Engr-AllanG
Copy link

  • Installed via docker compose in proxmox container running ubuntu 18.04
  • Separate container running nginx reverse proxy
  • Everything seems to be working normally using my subdomain.domain.com
  • When I create a share link and paste it into a private browser for testing, it takes me to my login screen instead of a public view, which is what I expected. After I log in, it then goes to mydomain.com/photos

I am guessing this is related to my reverse proxy. Any tips on where to start looking? For what its worth, I am successfully using my reverse proxy with Nextcloud, Seafile, W10 blue iris, Cryptpad and 3 or 4 other applications, so i'm not a complete novice. But I can't seem to figure this one out. I'm not certain if its a bug or a configuration issue.

@alexislefebvre
Copy link
Contributor

If you reopen the link after being logged in, do you see the expected page?

@Engr-AllanG
Copy link
Author

@alexislefebvre no after logging in, the album share link gets redirected to my main photos folder. I noticed that the share link does not have "public" in it:
e.g. https://photo.mydomain.net/s/15ouucueev/share
But if I right click a photo in preview and copy link address - that one does have "public" in the link and it does work as intended:
e.g. https://photo.mydomain.net/api/v1/t/14b7285bb2b7bbe2140ca8546bb8abe7f2b384f2/public/fit_1280

this leads me to believe it is a photoprism issue. Thoughts?

@Engr-AllanG
Copy link
Author

Engr-AllanG commented Nov 18, 2020

I discovered the issue is related to having an expiration date on the link. Above the selection it says "Invalid DateTime". I'll have to check the date/time of the OS this evening. I suspect it is set incorrect. If it is correct, then maybe a bug.

With no expiration date, the share link works

@alexislefebvre
Copy link
Contributor

alexislefebvre commented Nov 18, 2020

You're right, we can see this error on https://demo.photoprism.org/albums/aqjyfk72jstm22m5/berge-2020 too:

image

And the share link https://demo.photoprism.org/s/1gxdaj4bas/berge-2020 doesn't work, like you described it.

@graciousgrey graciousgrey added the bug Something isn't working label Nov 19, 2020
@graciousgrey
Copy link
Member

Thanks for reporting, we will have a look at it on the weekend!

@Engr-AllanG Engr-AllanG changed the title Unable to share with public link Unable to share with public link with expiration date Nov 19, 2020
lastzero added a commit that referenced this issue Nov 22, 2020
Signed-off-by: Michael Mayer <michael@liquidbytes.net>
@lastzero lastzero self-assigned this Nov 22, 2020
@lastzero lastzero added the please-test Ready for acceptance test label Nov 22, 2020
@lastzero lastzero added this to the MVP milestone Nov 22, 2020
lastzero added a commit that referenced this issue Nov 22, 2020
Signed-off-by: Michael Mayer <michael@liquidbytes.net>
@Engr-AllanG
Copy link
Author

Engr-AllanG commented Nov 22, 2020

Just tested on new ubuntu 20.04 container - public album share link with expiration worked as expected! I didn't test the actual expiration of the link yet (will have to wait 24 hours), but the link itself functions.

Excellent app - I'm loving it

@lastzero lastzero added released Available in the stable release and removed please-test Ready for acceptance test labels Nov 23, 2020
@Mabenan
Copy link

Mabenan commented Sep 20, 2021

Hi, is this already released?

For me it doesnt work. Tested with stable docker image and on demo.
Screenshot_2021-09-20-13-54-44-614_com android chrome

@Mabenan
Copy link

Mabenan commented Sep 20, 2021

The link is accesible

Addition the expiration is entered in the database i checked with changing the seconds in db the link really expires.

@lastzero lastzero added please-test Ready for acceptance test and removed released Available in the stable release labels Sep 23, 2021
lastzero added a commit that referenced this issue Sep 23, 2021
Looks like a pure frontend issue: It tried finding a date in
"UpdatedAt" while the actual field name is "ModifiedAt".
@lastzero lastzero reopened this Sep 23, 2021
@lastzero lastzero changed the title Unable to share with public link with expiration date Albums: Broken share expiration date in form label Sep 23, 2021
@lastzero
Copy link
Member

Share form label is fixed: It tried finding a date in UpdatedAt while the actual name is ModifiedAt.

@graciousgrey graciousgrey added released Available in the stable release and removed please-test Ready for acceptance test labels Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Available in the stable release
Projects
Status: Release 🌈
Development

No branches or pull requests

5 participants