Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: Multi-select using long click doesn't work #832

Closed
adan89lion opened this issue Jan 6, 2021 · 9 comments
Closed

iOS: Multi-select using long click doesn't work #832

adan89lion opened this issue Jan 6, 2021 · 9 comments
Assignees
Labels
bug Something isn't working frontend Requires experience with HTML/JS/CSS released Available in the stable release

Comments

@adan89lion
Copy link
Contributor

Hi,

I’ve recently switched my workflow from macOS to iPadOS, and encountered multi-selecting issues with Safari on mobile devices.

Step to reproduce:

  1. Open PhotoPrism instance on iOS, with Safari or Chrome [1]
  2. Open Review tab (or photo stream, or any album)
  3. Select the first image
  4. Long press the last image to make a selection
  5. Doesn't select images, but shows out text selection frame

Expected behaviour:
Make a selection from the first selected image to the long pressed image.

What went wrong?
It calls out Safari’s text selector

Did it work before?
It works perfectly on Android’s Chromium based browsers (tested on Chrome, Brave and Samsung Internet) and Fennec. This issue does not apply to desktop based systems (since we use Shift and Control to select massively)

Other notes:
N/A

[1] Browsers on iOS / iPadOS are all using WebKit, so any browser will have the same issue.

@lastzero
Copy link
Member

lastzero commented Jan 6, 2021

Might be handling DOM / JS events differently. Needs to be debugged and fixed in this case.

@lastzero lastzero added the bug Something isn't working label Jan 6, 2021
@lastzero lastzero changed the title Bug with bulk selection in iOS (Safari) iOS: Multi-select using long click doesn't work Jan 6, 2021
@lastzero lastzero added the frontend Requires experience with HTML/JS/CSS label Jan 6, 2021
@lastzero
Copy link
Member

Just ordered an iPad so that I can test this properly:

ipad

If you're not a sponsor yet, consider supporting us financially. Thank you! ❤️

@lastzero
Copy link
Member

lastzero commented Jan 15, 2021 via email

@lastzero
Copy link
Member

lastzero commented Jan 15, 2021

Browserstack is $468 per year minimum with iOS & Android devices, so about the same price except we don't get an actual device to test with.

@alexislefebvre
Copy link
Contributor

(I removed my previous comment shortly after posting it, I thought it wasn't heplful, and you proved it)

@lastzero
Copy link
Member

No worries 🌈 iPad should arrive tomorrow so that I can test all issues and hopefully fix them! No iOS device anymore since I switched to Huawei because of the excellent camera. Using a simulator is not the same by any standard.

lastzero added a commit that referenced this issue Jan 16, 2021
@lastzero lastzero self-assigned this Jan 16, 2021
@lastzero lastzero added the please-test Ready for acceptance test label Jan 16, 2021
@lastzero
Copy link
Member

Let us know if this works for you :)

Maybe @benmccann can have a second look at event handling 👀

@benmccann
Copy link
Contributor

I'm not on iOS either, so can't really test. BrowserStack will give free accounts for open source if it's helpful. I have one with all the bells and whistles

@lastzero
Copy link
Member

I'm not on iOS either, so can't really test. BrowserStack will give free accounts for open source if it's helpful. I have one with all the bells and whistles

Saw that. Probably takes a couple of days until we may get approved. Even then, it's a tool for testing - not for UX optimization. Need the real experience. Feels much better now.

Don't 100% like how click and touch events are mixed, also not sure if there are edge cases when multiple fingers are being used. Anyhow, major improvement to what we had before.

@lastzero lastzero removed the please-test Ready for acceptance test label Jan 19, 2021
@lastzero lastzero added the released Available in the stable release label Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Requires experience with HTML/JS/CSS released Available in the stable release
Projects
Status: Release 🌈
Development

No branches or pull requests

4 participants