Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: display video player in lightbox #843

Closed
benmccann opened this issue Jan 7, 2021 · 23 comments
Closed

UX: display video player in lightbox #843

benmccann opened this issue Jan 7, 2021 · 23 comments
Labels
duplicate This issue or pull request already exists

Comments

@benmccann
Copy link
Contributor

When you view a photo it shows it on a dark background. When you view a video you still see the PhotoPrism app in the background. It would be nice to make it display with the same background as a photo for consistency and to remove the distraction of seeing the app in the background

@lastzero
Copy link
Member

lastzero commented Jan 7, 2021

Seems there are different opinions on this 🤔

You can make it fullscreen for now... the video player doesn't have prev / next controls like the photo viewer, so it would just be an unused, black frame. Ideally, we have our own combined photo & video lightbox later so that you always get the same experience - independent of the media format.

@lastzero lastzero added the idea Feedback wanted / feature request label Jan 7, 2021
@benmccann
Copy link
Contributor Author

For what it's worth, Google also uses a black background with it's video player

@alexislefebvre
Copy link
Contributor

alexislefebvre commented Jan 31, 2021

I just discovered a different video player interface.

Instead of clicking on the video, click on the title, then on the preview image, then on the play button at the bottom, and you'll have a dark background around the video.

@graciousgrey
Copy link
Member

The new video player is much darker than the old one. Is it dark enough @benmccann ?

@alexislefebvre
Copy link
Contributor

Is there a reason to have different backgrounds for photos and videos? On the demo website, I can't see the background when viewing a photo, but I can see the UI when viewing a video.

@lastzero
Copy link
Member

lastzero commented Feb 9, 2021

We like it this way, but are willing to add yet another setting for this 😅 Telegram for example also uses a semi transparent background for videos...

@lastzero
Copy link
Member

lastzero commented Feb 9, 2021

Also many videos are much smaller than photos, although that may change with 4k ultra HD long-term. Don't believe a big black border looks good or modern. If you have other insights, please share.

@alexislefebvre
Copy link
Contributor

I'm sorry but I don't understand the "big black border" part. Like on photo viewer?

Here is the result on my screen with media with similar ratio:

Photo:

image

Video:

image

I find the flower distracting.

@lastzero
Copy link
Member

lastzero commented Feb 9, 2021

Try a 640x480 video, not the iPad air retina screen recording.

@alexislefebvre
Copy link
Contributor

alexislefebvre commented Feb 9, 2021

I tried and well, make up your own mind:

image

Oops, I forgot to update the Docker, here it is with the last preview tag:

image

People who prefer a dark background can still use the "dark" player. So, that's fine.

@benmccann
Copy link
Contributor Author

I think it's distracting to see something behind the video regardless of video size (and in fact worse with smaller videos since you see more other stuff) and inconsistent with the photo viewer

I'm not sure how many settings we'd want to add. It seems like it'd become difficult to maintain them all. But maybe video player background color could be part of a theme?

@lastzero
Copy link
Member

lastzero commented Feb 9, 2021

Same when you open it in Windows or macOS. Why not make it full screen? Why full attention on a small video?

@lastzero
Copy link
Member

lastzero commented Feb 9, 2021

Happy to make this part of a theme... Easy to change.

@benmccann
Copy link
Contributor Author

I'm not quite sure I understood the Mac/Windows thing cause I don't have either of those OSes. But I think you're saying the video player doesn't open full screen so you see stuff outside the video player. The other side of that though is that the rest of the video player background is black I believe. So the analogy here would be that the video player background would be dark and you could make Chrome not full screen and see other apps behind Chrome.

@lastzero
Copy link
Member

lastzero commented Feb 9, 2021

Either I want to have a quick look what the videos is, then I don't mind seeing the context. Just like when browsing a video folder on whatever operating system. When I want to enjoy a full length video without distraction, I always make it full screen like on every TV out there.

@lastzero
Copy link
Member

lastzero commented Feb 9, 2021

Note that the photo viewer has prev, next and action buttons, so I don't need context as it's a complete "app" by itself.

@lastzero
Copy link
Member

lastzero commented Feb 9, 2021

These are top ranked "browse videos" example screenshots on Google image search:

guida-windows-10-supporto-mkv-quotmatroskaquot-h 265-tutte-altre-novita-ambito-audio-video-windows-10-mkv-matroska-shell-2903 img
Videodateien_direkt_im_Quad-Explorer_betrachten_unter_Windows_10_2019-06-12-16-43-59

@benmccann
Copy link
Contributor Author

I think that the video player should also have prev and next buttons. It's strange to me that if I click the second thumbnail on https://demo.photoprism.org/browse that I can go back to the video or forward to the next picture, but if I click the video I can't go back or forwards. It's just as desirable for me to go from one video clip to the next as it is to go from one photo to the next.

On Google Photos I can use arrow keys or prev and next buttons regardless of whether it's a photo or a video.

@lastzero
Copy link
Member

lastzero commented Feb 9, 2021

Enjoy what we have in store now and stay tuned for more. Again, I don't enjoy Google photos and don't want to copy it 1:1 even though it may be the gold standard for you. It's clear we need our own combined viewer for photos and videos. It must also support lazy loading. Just can't deliver it by tomorrow, also given we didn't reach our funding goal yet and should focus on facial recognition plus your pull requests next...

@lastzero
Copy link
Member

lastzero commented Feb 9, 2021

Googles YouTube is also not exactly distraction free if not in full screen mode:

Screenshot 2021-02-10 at 11 22 34

Are videos really something you consume like photos and just keep on swiping through? Not my medium, I'm a photographer mainly 📸

@benmccann
Copy link
Contributor Author

Are videos really something you consume like photos and just keep in swiping through?

Yep. Most of my pictures and videos are of my kid. Most of the videos are just 5-10s clips of her doing something cute/funny, so very easy to scroll through a bunch of these in one sitting. I'll consume them like a stream and don't really care whether they're pics or videos. Just want to see them all and swipe from one to the next

@lastzero
Copy link
Member

@benmccann We'll keep that in mind moving forward 👍

@graciousgrey
Copy link
Member

I will close this ticket as duplicate. It will be implemented as part of this ticket: #1307

@graciousgrey graciousgrey added duplicate This issue or pull request already exists and removed idea Feedback wanted / feature request labels May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

4 participants