-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX: display video player in lightbox #843
Comments
Seems there are different opinions on this 🤔 You can make it fullscreen for now... the video player doesn't have prev / next controls like the photo viewer, so it would just be an unused, black frame. Ideally, we have our own combined photo & video lightbox later so that you always get the same experience - independent of the media format. |
For what it's worth, Google also uses a black background with it's video player |
I just discovered a different video player interface. Instead of clicking on the video, click on the title, then on the preview image, then on the play button at the bottom, and you'll have a dark background around the video. |
The new video player is much darker than the old one. Is it dark enough @benmccann ? |
Is there a reason to have different backgrounds for photos and videos? On the demo website, I can't see the background when viewing a photo, but I can see the UI when viewing a video. |
We like it this way, but are willing to add yet another setting for this 😅 Telegram for example also uses a semi transparent background for videos... |
Also many videos are much smaller than photos, although that may change with 4k ultra HD long-term. Don't believe a big black border looks good or modern. If you have other insights, please share. |
Try a 640x480 video, not the iPad air retina screen recording. |
I tried and well, make up your own mind: Oops, I forgot to update the Docker, here it is with the last preview tag: People who prefer a dark background can still use the "dark" player. So, that's fine. |
I think it's distracting to see something behind the video regardless of video size (and in fact worse with smaller videos since you see more other stuff) and inconsistent with the photo viewer I'm not sure how many settings we'd want to add. It seems like it'd become difficult to maintain them all. But maybe video player background color could be part of a theme? |
Same when you open it in Windows or macOS. Why not make it full screen? Why full attention on a small video? |
Happy to make this part of a theme... Easy to change. |
I'm not quite sure I understood the Mac/Windows thing cause I don't have either of those OSes. But I think you're saying the video player doesn't open full screen so you see stuff outside the video player. The other side of that though is that the rest of the video player background is black I believe. So the analogy here would be that the video player background would be dark and you could make Chrome not full screen and see other apps behind Chrome. |
Either I want to have a quick look what the videos is, then I don't mind seeing the context. Just like when browsing a video folder on whatever operating system. When I want to enjoy a full length video without distraction, I always make it full screen like on every TV out there. |
Note that the photo viewer has prev, next and action buttons, so I don't need context as it's a complete "app" by itself. |
I think that the video player should also have prev and next buttons. It's strange to me that if I click the second thumbnail on https://demo.photoprism.org/browse that I can go back to the video or forward to the next picture, but if I click the video I can't go back or forwards. It's just as desirable for me to go from one video clip to the next as it is to go from one photo to the next. On Google Photos I can use arrow keys or prev and next buttons regardless of whether it's a photo or a video. |
Enjoy what we have in store now and stay tuned for more. Again, I don't enjoy Google photos and don't want to copy it 1:1 even though it may be the gold standard for you. It's clear we need our own combined viewer for photos and videos. It must also support lazy loading. Just can't deliver it by tomorrow, also given we didn't reach our funding goal yet and should focus on facial recognition plus your pull requests next... |
Yep. Most of my pictures and videos are of my kid. Most of the videos are just 5-10s clips of her doing something cute/funny, so very easy to scroll through a bunch of these in one sitting. I'll consume them like a stream and don't really care whether they're pics or videos. Just want to see them all and swipe from one to the next |
@benmccann We'll keep that in mind moving forward 👍 |
I will close this ticket as duplicate. It will be implemented as part of this ticket: #1307 |
When you view a photo it shows it on a dark background. When you view a video you still see the PhotoPrism app in the background. It would be nice to make it display with the same background as a photo for consistency and to remove the distraction of seeing the app in the background
The text was updated successfully, but these errors were encountered: