New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharing: Albums page repeats the same results when scrolling #890
Comments
This is strange and doesn't happen on our demo as I just verified. We now also show shared folders, moments and months in the shared album overview. Are you sure you didn't share any of those as well? |
Hi, Yes, I am sure. These 54 albums are shared with the same token. I do not see any albums that are not shared. I see the same 54 albums getting repeated over and over again as I keep on scrolling down. So after a while I see the same album 3, 4 or more times. |
Does it depend on the screen size? |
Initially I checked it on my laptop. 1366x768. Now I checked it on my Samsung A51 android phone and the behaviour is the same. |
Can you test this again using today's preview image? |
Sure I can. Once tested, is there a way to go back to the stable release? Thanks. |
Simply change the Docker image name back, there are no database schema updates - just UI / UX. |
Maybe the same albums have been shared multiple times... can you try clearing your cache including local storage? |
I have checked with the latest preview (210117-f6081d9b-Linux-x86_64) and the behaviour has not changed. The albums are not shared multiple times. I have queried the database with: I don't think it's a browser cache issue either. As I have consistent behaviour from various browsers and computers. Also, I have been trying it in private browsing. |
Still can't reproduce it. Since you seem to access the db directly: Is it theoretically possible that you modified the tables / the data in any way? |
No, I have not. Would you like me to give you some level of access to my installation? |
Another interesting observation. Now I looked at the XHR requests in the Firefox web tools and it seems that for each "albums" request all the albums are returned, not just the 24 (e.g. count=24&offset=0, count=24&offset=24, count=24&offset=48 etc. all return all the 54 albums. The observed requests: The response is always the same: |
What proxy do you use? What settings? |
That was the right hint - should have tested with more than 24 IDs 😜 We didn't apply sort order and limit when searching for IDs as used in sharing. Fixed it for photos and labels as well. |
Very good question. Nginx. Basically I copy-pasted the config from the documentation and then I tweaked it a bit. Here are the anonymised config file:
|
Never mind, thought there were HTTP header issues but it was a server-side query issue (see above). |
You may test this using our preview image - it's like the stable release, just the fix added. |
Haha, in my initial post I intentionally called out 54 albums. And that I also had concerns with the sorting. Never mind, good to hear you managed to find the root cause of the issue. I am very glad. Thank you for looking into it. :) |
Do I need to wait for the build or can I pull it right now? |
See https://drone.photoprism.app/photoprism/photoprism/853/1/5 Looks done, only demo is still building.... ARM64 takes a bit longer. |
Thanks for reporting this and not giving up! ❤️ |
Tested. Works as expected. Thank you for fixing it.
No worries. Thank you for keep on investigating it and not giving up. Your efforts are much appreciated. I may come back with a couple of more bug reports or improvement ideas soon. ;) |
With the latest version (PhotoPrism® 210111-cc05c430-Linux-x86_64) I have noticed a bug.
I have 54 albums shared with the same share secret token. When I open the list of albums through the share token (as a guest) e.g. the https://mysite/s/token url and I keep on scrolling down then as I reach the end of the 54 albums then they start to get repeated over and over again.
In addition, previously this page probably showed the albums in alphabetical order whereas now it is a bit random.
The text was updated successfully, but these errors were encountered: