Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing: Albums page repeats the same results when scrolling #890

Closed
Sherlock1979 opened this issue Jan 13, 2021 · 22 comments
Closed

Sharing: Albums page repeats the same results when scrolling #890

Sherlock1979 opened this issue Jan 13, 2021 · 22 comments
Assignees
Labels
bug Something isn't working released Available in the stable release

Comments

@Sherlock1979
Copy link

With the latest version (PhotoPrism® 210111-cc05c430-Linux-x86_64) I have noticed a bug.

I have 54 albums shared with the same share secret token. When I open the list of albums through the share token (as a guest) e.g. the https://mysite/s/token url and I keep on scrolling down then as I reach the end of the 54 albums then they start to get repeated over and over again.

In addition, previously this page probably showed the albums in alphabetical order whereas now it is a bit random.

@lastzero
Copy link
Member

This is strange and doesn't happen on our demo as I just verified. We now also show shared folders, moments and months in the shared album overview. Are you sure you didn't share any of those as well?

@Sherlock1979
Copy link
Author

Hi,

Yes, I am sure. These 54 albums are shared with the same token. I do not see any albums that are not shared. I see the same 54 albums getting repeated over and over again as I keep on scrolling down. So after a while I see the same album 3, 4 or more times.

@lastzero
Copy link
Member

Does it depend on the screen size?

@Sherlock1979
Copy link
Author

Sherlock1979 commented Jan 13, 2021

Initially I checked it on my laptop. 1366x768.

Now I checked it on my Samsung A51 android phone and the behaviour is the same.

@lastzero lastzero self-assigned this Jan 13, 2021
@lastzero lastzero added the bug Something isn't working label Jan 13, 2021
@lastzero
Copy link
Member

Can you test this again using today's preview image?

@Sherlock1979
Copy link
Author

Sure I can. Once tested, is there a way to go back to the stable release? Thanks.

@lastzero
Copy link
Member

Simply change the Docker image name back, there are no database schema updates - just UI / UX.

@lastzero lastzero added the waiting Impediment / blocked / waiting label Jan 17, 2021
@lastzero
Copy link
Member

Maybe the same albums have been shared multiple times... can you try clearing your cache including local storage?

@lastzero lastzero added the help wanted Well suited for external contributors! label Jan 17, 2021
@Sherlock1979
Copy link
Author

I have checked with the latest preview (210117-f6081d9b-Linux-x86_64) and the behaviour has not changed.

The albums are not shared multiple times. I have queried the database with:
select share_slug from links where link_token like "mytoken";
... and each slug is there only once.

I don't think it's a browser cache issue either. As I have consistent behaviour from various browsers and computers. Also, I have been trying it in private browsing.

@lastzero
Copy link
Member

Still can't reproduce it. Since you seem to access the db directly: Is it theoretically possible that you modified the tables / the data in any way?

@Sherlock1979
Copy link
Author

No, I have not. Would you like me to give you some level of access to my installation?

@Sherlock1979
Copy link
Author

Sherlock1979 commented Jan 20, 2021

Another interesting observation. Now I looked at the XHR requests in the Firefox web tools and it seems that for each "albums" request all the albums are returned, not just the 24 (e.g. count=24&offset=0, count=24&offset=24, count=24&offset=48 etc. all return all the 54 albums.

The observed requests:
https://(hidden)/api/v1/albums?count=24&offset=0&q=&category=&type=
https://(hidden)/api/v1/albums?count=24&offset=24&q=&category=&type=
https://(hidden)/api/v1/albums?count=24&offset=48&q=&category=&type=
https://(hidden)/api/v1/albums?count=24&offset=72&q=&category=&type=

The response is always the same:
[{"UID":"aqmifqg1bk0tfi0z","CoverUID":"","FolderUID":"","Slug":"album-2018-04-03-connor-szuletese-nagyi","Type":"album","Title":"Album - 2018-04-03 Connor születése (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":318,"LinkCount":1,"CreatedAt":"2021-01-06T11:25:28Z","UpdatedAt":"2021-01-06T11:25:28Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmifqg1k9ea0ml4","CoverUID":"","FolderUID":"","Slug":"keptar-nagyi","Type":"album","Title":"Képtár (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":14531,"LinkCount":1,"CreatedAt":"2021-01-06T11:25:29Z","UpdatedAt":"2021-01-06T11:25:28Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmiga52fqy9rf0r","CoverUID":"","FolderUID":"","Slug":"album-2018-04-nagyi","Type":"album","Title":"Album - 2018-04 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":100,"LinkCount":1,"CreatedAt":"2021-01-06T11:37:17Z","UpdatedAt":"2021-01-06T11:37:17Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmiz091izs20um6","CoverUID":"","FolderUID":"","Slug":"album-2018-05-nagyi","Type":"album","Title":"Album - 2018-05 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":256,"LinkCount":1,"CreatedAt":"2021-01-06T18:21:46Z","UpdatedAt":"2021-01-06T18:21:45Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmiz7cxlr0vhwr5","CoverUID":"","FolderUID":"","Slug":"album-2018-06-24-manly-dam-marci-petra-eskuvoi-sutogetes-nagyi","Type":"album","Title":"Album - 2018-06-24 Manly Dam Marci Petra esküvői sütögetés (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":52,"LinkCount":1,"CreatedAt":"2021-01-06T18:26:01Z","UpdatedAt":"2021-01-06T18:26:01Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmizj31ohx02ql4","CoverUID":"","FolderUID":"","Slug":"album-2018-06-nagyi","Type":"album","Title":"Album - 2018-06 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":456,"LinkCount":1,"CreatedAt":"2021-01-06T18:33:04Z","UpdatedAt":"2021-01-06T18:33:03Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmj07n2lk298ffv","CoverUID":"","FolderUID":"","Slug":"album-2018-07-nagyi","Type":"album","Title":"Album - 2018-07 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":362,"LinkCount":1,"CreatedAt":"2021-01-06T18:47:47Z","UpdatedAt":"2021-01-06T18:47:47Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmj0wn1ct3oo0wn","CoverUID":"","FolderUID":"","Slug":"album-2018-08-nagyi","Type":"album","Title":"Album - 2018-08 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":512,"LinkCount":1,"CreatedAt":"2021-01-06T19:02:48Z","UpdatedAt":"2021-01-06T19:02:47Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmj1rec4gywv04w","CoverUID":"","FolderUID":"","Slug":"album-2018-09-nagyi","Type":"album","Title":"Album - 2018-09 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":496,"LinkCount":1,"CreatedAt":"2021-01-06T19:21:14Z","UpdatedAt":"2021-01-06T19:21:14Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmj2ccixoi7ipn1","CoverUID":"","FolderUID":"","Slug":"album-2018-10-09-balmoral-seta-nagyi","Type":"album","Title":"Album - 2018-10-09 Balmoral séta (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":41,"LinkCount":1,"CreatedAt":"2021-01-06T19:33:49Z","UpdatedAt":"2021-01-06T19:33:48Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmj2e637dv65rme","CoverUID":"","FolderUID":"","Slug":"album-2018-10-25-vacsi-rhodesban-nagyi","Type":"album","Title":"Album - 2018-10-25 Vacsi Rhodesban (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":25,"LinkCount":1,"CreatedAt":"2021-01-06T19:34:55Z","UpdatedAt":"2021-01-06T19:34:54Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmj2oo3w35uyvcw","CoverUID":"","FolderUID":"","Slug":"album-2018-10-nagyi","Type":"album","Title":"Album - 2018-10 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":373,"LinkCount":1,"CreatedAt":"2021-01-06T19:41:12Z","UpdatedAt":"2021-01-06T19:41:12Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmj3uwfg8jwkyax","CoverUID":"","FolderUID":"","Slug":"album-2018-11-02-balmoral-beach-elso-strandolas-reniekkel-es-dittaval-nagy-aqmj3uwfg8jwkyax","Type":"album","Title":"Album - 2018-11-02 Balmoral Beach első strandolás (Reniékkel és Dittával) (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":58,"LinkCount":1,"CreatedAt":"2021-01-06T20:06:33Z","UpdatedAt":"2021-01-06T20:06:32Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmj3yqplvnw4p8f","CoverUID":"","FolderUID":"","Slug":"album-2018-11-16-tarronga-zoo-allatkerti-seta-dittaval-renivel-ibisszel-na-aqmj3yqplvnw4p8f","Type":"album","Title":"Album - 2018-11-16 Tarronga Zoo állatkerti séta Dittával, Renivel, Ibisszel (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":36,"LinkCount":1,"CreatedAt":"2021-01-06T20:08:50Z","UpdatedAt":"2021-01-06T20:08:50Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmj44s2ojx47cpu","CoverUID":"","FolderUID":"","Slug":"album-2018-11-nagyi","Type":"album","Title":"Album - 2018-11 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":180,"LinkCount":1,"CreatedAt":"2021-01-06T20:12:28Z","UpdatedAt":"2021-01-06T20:12:28Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmj4be19eknz689","CoverUID":"","FolderUID":"","Slug":"album-2018-12-29-manly-shelly-beach-strandolas-nagyi","Type":"album","Title":"Album - 2018-12-29 Manly Shelly Beach strandolás (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":59,"LinkCount":1,"CreatedAt":"2021-01-06T20:16:27Z","UpdatedAt":"2021-01-06T20:16:26Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmj4cw1x0d0rjol","CoverUID":"","FolderUID":"","Slug":"album-2018-12-27-dee-why-strandolas-lucaval-nagyi","Type":"album","Title":"Album - 2018-12-27 Dee Why strandolás Lucával (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":74,"LinkCount":1,"CreatedAt":"2021-01-06T20:17:21Z","UpdatedAt":"2021-01-06T20:17:21Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmj4etyk8oeltme","CoverUID":"","FolderUID":"","Slug":"album-2018-12-17-pancsolas-az-erkelyen-es-strandolas-dee-why-on-nagyi","Type":"album","Title":"Album - 2018-12-17 Pancsolás az erkélyen és strandolás Dee Why-on (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":124,"LinkCount":1,"CreatedAt":"2021-01-06T20:18:29Z","UpdatedAt":"2021-01-06T20:18:29Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmj4uubjktiag61","CoverUID":"","FolderUID":"","Slug":"album-2018-12-nagyi","Type":"album","Title":"Album - 2018-12 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":360,"LinkCount":1,"CreatedAt":"2021-01-06T20:28:06Z","UpdatedAt":"2021-01-06T20:28:06Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmj5nt159b45dqk","CoverUID":"","FolderUID":"","Slug":"album-2019-01-16-furdes-a-kadban-nagyi","Type":"album","Title":"Album - 2019-01-16 Fürdés a kádban (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":14,"LinkCount":1,"CreatedAt":"2021-01-06T20:45:29Z","UpdatedAt":"2021-01-06T20:45:29Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmj5o82kwihgbqr","CoverUID":"","FolderUID":"","Slug":"album-2019-01-05-narrabeen-lakes-strandolas-nagyi","Type":"album","Title":"Album - 2019-01-05 Narrabeen Lakes strandolás (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":77,"LinkCount":1,"CreatedAt":"2021-01-06T20:45:44Z","UpdatedAt":"2021-01-06T20:45:44Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmj5qd1cerrn282","CoverUID":"","FolderUID":"","Slug":"album-2019-01-01-ujevi-pancsolas-nagyi","Type":"album","Title":"Album - 2019-01-01 Újévi pancsolás (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":38,"LinkCount":1,"CreatedAt":"2021-01-06T20:47:02Z","UpdatedAt":"2021-01-06T20:47:01Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmj5wz3kn6rpqog","CoverUID":"","FolderUID":"","Slug":"album-2019-01-nagyi","Type":"album","Title":"Album - 2019-01 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":317,"LinkCount":1,"CreatedAt":"2021-01-06T20:50:59Z","UpdatedAt":"2021-01-06T20:50:59Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmj6d0374ryb684","CoverUID":"","FolderUID":"","Slug":"album-2019-02-nagyi","Type":"album","Title":"Album - 2019-02 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":293,"LinkCount":1,"CreatedAt":"2021-01-06T21:00:36Z","UpdatedAt":"2021-01-06T21:00:36Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmj6tb3j60una2v","CoverUID":"","FolderUID":"","Slug":"album-2019-03-nagyi","Type":"album","Title":"Album - 2019-03 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":418,"LinkCount":1,"CreatedAt":"2021-01-06T21:10:23Z","UpdatedAt":"2021-01-06T21:10:23Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmjbmj1s8b1dfyz","CoverUID":"","FolderUID":"","Slug":"album-2019-04-nagyi","Type":"album","Title":"Album - 2019-04 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":708,"LinkCount":1,"CreatedAt":"2021-01-06T22:54:20Z","UpdatedAt":"2021-01-06T22:54:19Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmjd2znkk5lmbtc","CoverUID":"","FolderUID":"","Slug":"album-2019-05-nagyi","Type":"album","Title":"Album - 2019-05 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":447,"LinkCount":1,"CreatedAt":"2021-01-06T23:25:47Z","UpdatedAt":"2021-01-06T23:25:47Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmjfe32et735hjy","CoverUID":"","FolderUID":"","Slug":"album-2019-06-nagyi","Type":"album","Title":"Album - 2019-06 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":378,"LinkCount":1,"CreatedAt":"2021-01-07T00:15:40Z","UpdatedAt":"2021-01-07T00:15:40Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmjloa29wdcy6an","CoverUID":"","FolderUID":"","Slug":"album-2019-07-nagyi","Type":"album","Title":"Album - 2019-07 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":108,"LinkCount":1,"CreatedAt":"2021-01-07T02:31:22Z","UpdatedAt":"2021-01-07T02:31:22Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmjpoaw7tifgifh","CoverUID":"","FolderUID":"","Slug":"album-2019-07-2019-08-magyarorszag-nagyi","Type":"album","Title":"Album - 2019-07 - 2019-08 Magyarország (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":681,"LinkCount":1,"CreatedAt":"2021-01-07T03:57:47Z","UpdatedAt":"2021-01-07T03:57:46Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmjt5zaxrz0eh57","CoverUID":"","FolderUID":"","Slug":"album-2019-09-nagyi","Type":"album","Title":"Album - 2019-09 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":347,"LinkCount":1,"CreatedAt":"2021-01-07T05:13:11Z","UpdatedAt":"2021-01-07T05:13:11Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmju12hn323g1g8","CoverUID":"","FolderUID":"","Slug":"album-2019-08-nagyi","Type":"album","Title":"Album - 2019-08 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":63,"LinkCount":1,"CreatedAt":"2021-01-07T05:31:50Z","UpdatedAt":"2021-01-07T05:31:50Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmjudg3vs3rw6wo","CoverUID":"","FolderUID":"","Slug":"album-2019-12-27-aquatic-centre-matty-vel-nagyi","Type":"album","Title":"Album - 2019-12-27 Aquatic Centre Matty-vel (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":101,"LinkCount":1,"CreatedAt":"2021-01-07T05:39:17Z","UpdatedAt":"2021-01-07T05:39:16Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmjuly3fuc614li","CoverUID":"","FolderUID":"","Slug":"album-2019-11-nagyi","Type":"album","Title":"Album - 2019-11 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":525,"LinkCount":1,"CreatedAt":"2021-01-07T05:44:22Z","UpdatedAt":"2021-01-07T05:44:22Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmjvwecq48ygs9h","CoverUID":"","FolderUID":"","Slug":"album-2019-10-nagyi","Type":"album","Title":"Album - 2019-10 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":494,"LinkCount":1,"CreatedAt":"2021-01-07T06:12:15Z","UpdatedAt":"2021-01-07T06:12:15Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqml6ar3uvz9al6y","CoverUID":"","FolderUID":"","Slug":"album-2020-09-19-ryde-aquatic-centre-nagyi","Type":"album","Title":"Album - 2020-09-19 Ryde Aquatic Centre (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":52,"LinkCount":1,"CreatedAt":"2021-01-07T22:54:27Z","UpdatedAt":"2021-01-07T22:54:27Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmoljq3s4b9fws5","CoverUID":"","FolderUID":"","Slug":"album-2019-12-nagyi","Type":"album","Title":"Album - 2019-12 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":348,"LinkCount":1,"CreatedAt":"2021-01-09T19:16:39Z","UpdatedAt":"2021-01-09T19:16:38Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmr9w32v5cu4y33","CoverUID":"","FolderUID":"","Slug":"album-2020-01-nagyi","Type":"album","Title":"Album - 2020-01 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":266,"LinkCount":1,"CreatedAt":"2021-01-11T05:57:40Z","UpdatedAt":"2021-01-11T05:57:40Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmrmyhwhbj05ggh","CoverUID":"","FolderUID":"","Slug":"album-2020-02-nagyi","Type":"album","Title":"Album - 2020-02 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":478,"LinkCount":1,"CreatedAt":"2021-01-11T10:39:53Z","UpdatedAt":"2021-01-11T10:39:53Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqms9id30totn21k","CoverUID":"","FolderUID":"","Slug":"album-2020-03-nagyi","Type":"album","Title":"Album - 2020-03 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":291,"LinkCount":1,"CreatedAt":"2021-01-11T18:47:02Z","UpdatedAt":"2021-01-11T18:47:01Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmsae31nd7w15an","CoverUID":"","FolderUID":"","Slug":"album-2020-04-nagyi","Type":"album","Title":"Album - 2020-04 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":274,"LinkCount":1,"CreatedAt":"2021-01-11T19:06:04Z","UpdatedAt":"2021-01-11T19:06:04Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmsfv72f9hhth8p","CoverUID":"","FolderUID":"","Slug":"album-2020-05-nagyi","Type":"album","Title":"Album - 2020-05 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":363,"LinkCount":1,"CreatedAt":"2021-01-11T21:04:20Z","UpdatedAt":"2021-01-11T21:04:19Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmsk9xp351574av","CoverUID":"","FolderUID":"","Slug":"album-2020-06-nagyi","Type":"album","Title":"Album - 2020-06 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":423,"LinkCount":1,"CreatedAt":"2021-01-11T22:39:33Z","UpdatedAt":"2021-01-11T22:39:33Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmsllr2icr5wg9q","CoverUID":"","FolderUID":"","Slug":"album-2020-07-nagyi","Type":"album","Title":"Album - 2020-07 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":315,"LinkCount":1,"CreatedAt":"2021-01-11T23:08:16Z","UpdatedAt":"2021-01-11T23:08:16Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmsmkm2cwy7nydg","CoverUID":"","FolderUID":"","Slug":"album-2020-08-nagyi","Type":"album","Title":"Album - 2020-08 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":454,"LinkCount":1,"CreatedAt":"2021-01-11T23:29:11Z","UpdatedAt":"2021-01-11T23:29:11Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmso99ixhe2o5p4","CoverUID":"","FolderUID":"","Slug":"album-2020-09-nagyi","Type":"album","Title":"Album - 2020-09 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":410,"LinkCount":1,"CreatedAt":"2021-01-12T00:05:34Z","UpdatedAt":"2021-01-12T00:05:33Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmspjafo1xzrf2w","CoverUID":"","FolderUID":"","Slug":"album-2020-10-nagyi","Type":"album","Title":"Album - 2020-10 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":532,"LinkCount":1,"CreatedAt":"2021-01-12T00:33:10Z","UpdatedAt":"2021-01-12T00:33:10Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmsr1g2eicfikik","CoverUID":"","FolderUID":"","Slug":"album-2020-10-04-narrabeen-lake-nagyi","Type":"album","Title":"Album - 2020-10-04 Narrabeen Lake (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":23,"LinkCount":1,"CreatedAt":"2021-01-12T01:05:41Z","UpdatedAt":"2021-01-12T01:05:41Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmsr6pw2vphuw4w","CoverUID":"","FolderUID":"","Slug":"album-2020-11-29-pancsolas-zsofieknal-nagyi","Type":"album","Title":"Album - 2020-11-29 Pancsolás Zsófiéknál (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":27,"LinkCount":1,"CreatedAt":"2021-01-12T01:08:50Z","UpdatedAt":"2021-01-12T01:08:49Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmsraa34l55bmaz","CoverUID":"","FolderUID":"","Slug":"album-2020-11-14-balmoral-beach-nagyi","Type":"album","Title":"Album - 2020-11-14 Balmoral Beach (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":54,"LinkCount":1,"CreatedAt":"2021-01-12T01:10:58Z","UpdatedAt":"2021-01-12T01:10:58Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmsrhehktevwbfs","CoverUID":"","FolderUID":"","Slug":"album-2020-11-13-sydney-olympic-park-aquatic-centre-nagyi","Type":"album","Title":"Album - 2020-11-13 Sydney Olympic Park Aquatic Centre (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":10,"LinkCount":1,"CreatedAt":"2021-01-12T01:15:15Z","UpdatedAt":"2021-01-12T01:15:14Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmtk9b1ki3sj2lf","CoverUID":"","FolderUID":"","Slug":"album-2020-12-nagyi","Type":"album","Title":"Album - 2020-12 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":537,"LinkCount":1,"CreatedAt":"2021-01-12T11:36:48Z","UpdatedAt":"2021-01-12T11:36:48Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmtm2f1cyn8ub6a","CoverUID":"","FolderUID":"","Slug":"album-2020-11-nagyi","Type":"album","Title":"Album - 2020-11 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":494,"LinkCount":1,"CreatedAt":"2021-01-12T12:15:51Z","UpdatedAt":"2021-01-12T12:15:51Z","DeletedAt":"0001-01-01T00:00:00Z"},{"UID":"aqmua1c3ii7qbmi5","CoverUID":"","FolderUID":"","Slug":"album-2021-01-nagyi","Type":"album","Title":"Album - 2021-01 (nagyi)","Location":"","Category":"","Caption":"","Description":"","Notes":"","Filter":"","Order":"newest","Template":"","Path":"","Country":"zz","Year":0,"Month":0,"Day":0,"Favorite":false,"Private":false,"PhotoCount":366,"LinkCount":1,"CreatedAt":"2021-01-12T20:53:37Z","UpdatedAt":"2021-01-12T20:53:37Z","DeletedAt":"0001-01-01T00:00:00Z"}]

@lastzero
Copy link
Member

What proxy do you use? What settings?

@lastzero
Copy link
Member

That was the right hint - should have tested with more than 24 IDs 😜

We didn't apply sort order and limit when searching for IDs as used in sharing. Fixed it for photos and labels as well.

@lastzero lastzero added please-test Ready for acceptance test and removed help wanted Well suited for external contributors! waiting Impediment / blocked / waiting labels Jan 20, 2021
@Sherlock1979
Copy link
Author

Very good question. Nginx. Basically I copy-pasted the config from the documentation and then I tweaked it a bit.

Here are the anonymised config file:

server {
    server_name (hidden);
    root (hidden);
    
    # Since the PP API is also used on Android, we have to keep TLS1.2 in here for a while.
    # A lot of the older Android devices do not support TLS1.3 yet :/
    ssl_protocols            TLSv1.2 TLSv1.3;
            
    # Use good and strong ciphers, disable weak and old ciphers
    ssl_ciphers              HIGH:!RC4:!aNULL:!eNULL:!LOW:!3DES:!MD5:!EXP:!PSK:!SRP:!DSS;

    # Enable HSTS (https://developer.mozilla.org/en-US/docs/Security/HTTP_Strict_Transport_Security)
    add_header Strict-Transport-Security "max-age=172800; includeSubdomains";
    
    # This checks if the certificate has been invalidated by the certificate authority
    # You can remove this section if you use self-singed certificates...
    # Enable OCSP stapling (http://blog.mozilla.org/security/2013/07/29/ocsp-stapling-in-firefox)
    ssl_stapling on;
    ssl_stapling_verify on;
    ssl_trusted_certificate /etc/letsencrypt/live/(hidden)/fullchain.pem;
        
    # DNS Servers to use for OCSP lookups
    resolver 8.8.8.8 1.1.1.1 9.9.9.9 valid=300s;
    resolver_timeout 5s;
    
    # Reverse Proxy
    proxy_redirect           off;
    proxy_set_header         X-Real-IP $remote_addr;                        # Let PP know the clients real IP
    proxy_set_header         X-Forwarded-For $proxy_add_x_forwarded_for;    # Let PP know that a proxy did forward this request
    proxy_set_header         Host $host;                               # Set Proxy host info

    proxy_http_version 1.1;                                                 # Required for WebSocket connection
    proxy_set_header Upgrade $http_upgrade;                                 # Allow protocol switch to websocket
    proxy_set_header Connection "upgrade";                                  # Do protocol switch
    proxy_set_header X-Forwarded-Proto $scheme;                             # Let PP know that this connection used HTTP or HTTPS

    client_max_body_size 500M;                                              # Bump the max body size, you may want to upload huge stuff via the upload
    proxy_buffering off;                                                    # Do not hold back the request while the client sends data, give the stream

    access_log        (hidden);
    error_log        (hidden);

    listen 443 ssl http2; # managed by Certbot
    ssl_certificate /etc/letsencrypt/live/(hidden)/fullchain.pem; # managed by Certbot
    ssl_certificate_key /etc/letsencrypt/live/(hidden)/privkey.pem; # managed by Certbot
    # include /etc/letsencrypt/options-ssl-nginx.conf; # managed by Certbot
    ssl_dhparam /etc/letsencrypt/ssl-dhparams.pem; # managed by Certbot
            
    proxy_intercept_errors on;
    fastcgi_intercept_errors on;

    location / {
        proxy_pass http://10.132.64.99:2342;
    }
}

server {
    if ($host = (hidden)) {
        return 301 https://$host$request_uri;
    } # managed by Certbot

    server_name (hidden);
    listen 80;
    return 404; # managed by Certbot
}

@lastzero
Copy link
Member

Never mind, thought there were HTTP header issues but it was a server-side query issue (see above).

@lastzero
Copy link
Member

You may test this using our preview image - it's like the stable release, just the fix added.

@Sherlock1979
Copy link
Author

Sherlock1979 commented Jan 20, 2021

That was the right hint - should have tested with more than 24 IDs stuck_out_tongue_winking_eye

We didn't apply sort order and limit when searching for IDs as used in sharing. Fixed it for photos and labels as well.

Haha, in my initial post I intentionally called out 54 albums. And that I also had concerns with the sorting. Never mind, good to hear you managed to find the root cause of the issue. I am very glad. Thank you for looking into it. :)

@Sherlock1979
Copy link
Author

You may test this using our preview image - it's like the stable release, just the fix added.

Do I need to wait for the build or can I pull it right now?

@lastzero
Copy link
Member

See https://drone.photoprism.app/photoprism/photoprism/853/1/5

Looks done, only demo is still building.... ARM64 takes a bit longer.

@lastzero
Copy link
Member

Thanks for reporting this and not giving up! ❤️

@Sherlock1979
Copy link
Author

Tested. Works as expected. Thank you for fixing it.

Thanks for reporting this and not giving up! heart

No worries. Thank you for keep on investigating it and not giving up. Your efforts are much appreciated.

I may come back with a couple of more bug reports or improvement ideas soon. ;)

@lastzero lastzero changed the title Infinite Scrolling keeps on repeating the same albums over and over again in shared view Sharing: Albums page ignores count and offset, repeats the same results when scrolling Jan 20, 2021
@lastzero lastzero changed the title Sharing: Albums page ignores count and offset, repeats the same results when scrolling Sharing: Albums page repeats the same results when scrolling Jan 20, 2021
@lastzero lastzero added released Available in the stable release and removed please-test Ready for acceptance test labels Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Available in the stable release
Projects
Status: Release 🌈
Development

No branches or pull requests

2 participants