Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata / Estimate timezone #914

Closed
graciousgrey opened this issue Jan 18, 2021 · 2 comments
Closed

Metadata / Estimate timezone #914

graciousgrey opened this issue Jan 18, 2021 · 2 comments
Assignees
@lastzero
Labels
idea Feedback wanted / feature request released Available in the stable release

Comments

@graciousgrey
Copy link
Member

graciousgrey commented Jan 18, 2021 •
edited

As a user I want PhotoPrism to estimate the timezone of my images so that the sorting with other photos with a similar time is correct
@graciousgrey graciousgrey added the idea Feedback wanted / feature request label Jan 18, 2021
@lastzero lastzero self-assigned this Jan 18, 2021
lastzero added a commit that referenced this issue Jan 19, 2021
@lastzero
Metadata: Set time zone based on pictures taken at a similar time #914
019a649
lastzero added a commit that referenced this issue Jan 19, 2021
@lastzero
Metadata: Improve time zone estimates #914
6ee2613
@benmccann
Copy link
Contributor

benmccann commented Jan 19, 2021 •
edited

Wouldn't they be in the same order either way?

@graciousgrey graciousgrey changed the title UX / Add option to sort files by local time Metadata / Estimate timezone Jan 20, 2021
@graciousgrey graciousgrey added the released Available in the stable release label Jan 20, 2021
@graciousgrey
Copy link
Member Author

@benmccann The problem here was that images from one device had a time + timezone: e.g. 19:00 CET (which is 18:00 UTC). Another image had only a time but no information about the timezone e.g. 18:45 in this case 18:45 was set as local time and UTC time.
As we sort by UTC the 19:00 image was sorted before the 18:45 image.
Instead of adding more config options we decided to estimate the timezone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lastzero lastzero

Labels
idea Feedback wanted / feature request released Available in the stable release
Projects
Roadmap 🚀✨
Status: Release 🌈
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lastzero @benmccann @graciousgrey