Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Norwegian translation #1079

Merged
merged 3 commits into from Feb 20, 2021
Merged

Add Norwegian translation #1079

merged 3 commits into from Feb 20, 2021

Conversation

ohjohnsen
Copy link
Contributor

Adding Norwegian translation for the frontend. Was not able to build and test locally, so the translation is untested.

@CLAassistant
Copy link

CLAassistant commented Feb 19, 2021

CLA assistant check
All committers have signed the CLA.

@lastzero
Copy link
Member

Thank you very much! frontend/src/locales/nb.mo should not be empty, but guess we can fit it :)

@ohjohnsen
Copy link
Contributor Author

Hmm.. I don't understand why the file is empty. I see that in the "Files changed" tab in the PR that GitHub says the .mo file is an "Empty file". But in both my local feature branch in my forked repo and when just downloading an export of the feature branch from GitHub, the nb.mo file should be around 32kB size.

I used Poedit to translate though, so it could be that I didn't do a step before committing the translation. Please advice then and I will follow up.

@lastzero lastzero changed the title Feature/norwegian translation Add Norwegian translation Feb 20, 2021
@lastzero lastzero merged commit b142c38 into photoprism:develop Feb 20, 2021
@lastzero
Copy link
Member

norsk

@ohjohnsen
Copy link
Contributor Author

Awesome! :)

@ohjohnsen
Copy link
Contributor Author

ohjohnsen commented Feb 20, 2021

Can you rename it to "Norsk (Bokmål)"? We have two written Norwegian languages. "Norsk (Bokmål)" and "Norsk (Nynorsk)". Nynorsk is used extensively on the western part of Norway amongst other places. My wife is from western Norway (we live in Bergen), and I've more or less recruited her to add a Nynorsk translation later on (if you think this would be interesting to have in PhotoPrism). :-)

https://www.localeplanet.com/icu/nb/index.html
https://www.localeplanet.com/icu/nn/index.html

@lastzero lastzero added the released Available in the stable release label Feb 20, 2021
@lastzero
Copy link
Member

Saw that and wasn't sure how to handle it... thanks for the hint!

lastzero added a commit that referenced this pull request Feb 20, 2021
@lastzero
Copy link
Member

Done!

@lastzero
Copy link
Member

Demo will be updated in ~30 min so that you can test it there as well 🌈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Available in the stable release
Projects
Status: Release 🌈
Development

Successfully merging this pull request may close these issues.

None yet

3 participants