Backend: Add API endpoint for photo count per month #218
Conversation
|
|
|
I can merge this, but note that we'll probably change the URL in something like "/moments/time" as we also need it for the Web UI... additionally grouped by country, maybe like "/moments/country". Not sure where I have the query, but I've prepared it recently. |
|
|
||
| result, err := q.GetPhotoCountPerMonth() | ||
| if err != nil { | ||
| c.AbortWithStatusJSON(400, gin.H{"error": txt.UcFirst(err.Error())}) |
There was a problem hiding this comment.
Use the http.* constant instead of an integer
There was a problem hiding this comment.
good catch, would http.StatusInternalServerError be a good choice?
There was a problem hiding this comment.
Maybe yes, since this should never happen? Otherwise StatusBadRequest would be OK.
|
|
||
| // GET /api/v1/photoCountPerMonth | ||
| func GetPhotoCountPerMonth(router *gin.RouterGroup, conf *config.Config) { | ||
| router.GET("/photoCountPerMonth", func(c *gin.Context) { |
| q = q.Table("photos"). | ||
| Select("photos.photo_year, photos.photo_month, COUNT(*) AS count"). | ||
| Group("photos.photo_year, photos.photo_month"). | ||
| Order("photos.photo_year DESC, photos.photo_month DESC") |
There was a problem hiding this comment.
Looks good, but you might want to ignore deleted / archived photos for this?
| ) | ||
|
|
||
| // GET /api/v1/moments/time | ||
| func GetPhotoCountPerMonth(router *gin.RouterGroup, conf *config.Config) { |
There was a problem hiding this comment.
Can you also rename this to GetMomentsTime()? Looks good otherwise, probably need to add fixtures to properly test this with unit tests... we can do this later, so that you can focus on developing our mobile app :)
|
Cool, will be merged as soon as Travis CI is green 🥝 |
|
Also added you and @spaibs as team members to our org as you contribute a lot and maintain the mobile app. |
This new endpoint allows the mobile app to have a draggable scrollbar without loading the metadata for all photos.