Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Traditional Chinese translate #2890

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

RCXavierHK
Copy link
Contributor

Correct Traditional Chinese translation characters and actual meaning. by Hongkonger

I found that the translation is somehow based on the Google translate. Some words are in simplified Chinese instead of Traditional Chinese.

Acceptance Criteria:

  • Features and enhancements are fully implemented so that they can be released at any time without additional work
  • Automated unit and/or acceptance tests have been added to ensure the changes work as expected and to reduce repetitive manual work
  • User interface changes are fully responsive and have been tested on all major browsers and various devices
  • Database-related changes are compatible with SQLite and MariaDB
  • Translations have been updated - Tranditional Chinese (zh-TW)
  • Documentation has been / will be updated (specify if needed)
  • Contributor License Agreement (CLA) has been signed

Correct Traditional Chinese translation characters and actual meaning.
by Hongkonger
@CLAassistant
Copy link

CLAassistant commented Nov 14, 2022

CLA assistant check
All committers have signed the CLA.

@lastzero
Copy link
Member

Thanks a lot! Note that changing translations via pull request can cause merge conflicts if someone changes translations in our translation tool at the same time: https://translate.photoprism.app/projects/photoprism/backend/zh_Hant/

I will merge this quickly while there are no conflicts yet :)

@lastzero lastzero merged commit f639691 into photoprism:develop Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Release 🌈
Development

Successfully merging this pull request may close these issues.

None yet

3 participants