Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA: Fix app manifest logo icon sizes #3838

Merged
merged 1 commit into from Oct 23, 2023

Conversation

abrahampm
Copy link
Contributor

Logo icon 77.png does not exists so a warning is shown on Chrome Dev Tools when inspecting the PWA manifest.

Not sure if this is related with some users not getting the Install App button on Chrome. I came across this problem when trying to install the PWA on a mobile device and Install app button was not available so I decided to investigate. Hope this helps! ;)

Screenshot 2023-10-22 223400

Acceptance Criteria:

  • Features and enhancements must be fully implemented so that they can be released at any time without additional work
  • Automated unit and/or acceptance tests are mandatory to ensure the changes work as expected and to reduce repetitive manual work
  • Frontend components must be responsive to work and look properly on phones, tablets, and desktop computers; you must have tested them on all major browsers and different devices
  • Documentation and translation updates should be provided if needed
  • In case you submit database-related changes, they must be tested and compatible with SQLite 3 and MariaDB 10.5.12+

Logo icon 77.png does not exists so a warning is shown on Chrome Dev Tools when inspecting the PWA manifest
@CLAassistant
Copy link

CLAassistant commented Oct 23, 2023

CLA assistant check
All committers have signed the CLA.

@lastzero
Copy link
Member

Thank you very much! Must have been a typo...

@lastzero lastzero added the bug Something isn't working label Oct 23, 2023
@lastzero lastzero changed the title Fix PWA 77px logo icon size to 76px PWA: Fix app manifest logo icon sizes Oct 23, 2023
@lastzero lastzero added the merged Changes should be tested again after they have been integrated label Oct 23, 2023
@lastzero lastzero merged commit 50d6d6d into photoprism:develop Oct 23, 2023
2 checks passed
@lastzero lastzero added the please-test Ready for acceptance test label Oct 23, 2023
@graciousgrey graciousgrey added tested Changes have been tested successfully released Available in the stable release and removed please-test Ready for acceptance test labels Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working merged Changes should be tested again after they have been integrated released Available in the stable release tested Changes have been tested successfully
Projects
Status: Release 🌈
Development

Successfully merging this pull request may close these issues.

None yet

4 participants