Skip to content

PWA: Fix app manifest logo icon sizes - #3838

Merged
lastzero merged 1 commit into
photoprism:developfrom
abrahampm:fix-pwa-icon-sizes
Oct 23, 2023
Merged

PWA: Fix app manifest logo icon sizes#3838
lastzero merged 1 commit into
photoprism:developfrom
abrahampm:fix-pwa-icon-sizes

Conversation

@abrahampm

Copy link
Copy Markdown
Contributor

Logo icon 77.png does not exists so a warning is shown on Chrome Dev Tools when inspecting the PWA manifest.

Not sure if this is related with some users not getting the Install App button on Chrome. I came across this problem when trying to install the PWA on a mobile device and Install app button was not available so I decided to investigate. Hope this helps! ;)

Screenshot 2023-10-22 223400

Acceptance Criteria:

  • Features and enhancements must be fully implemented so that they can be released at any time without additional work
  • Automated unit and/or acceptance tests are mandatory to ensure the changes work as expected and to reduce repetitive manual work
  • Frontend components must be responsive to work and look properly on phones, tablets, and desktop computers; you must have tested them on all major browsers and different devices
  • Documentation and translation updates should be provided if needed
  • In case you submit database-related changes, they must be tested and compatible with SQLite 3 and MariaDB 10.5.12+

Logo icon 77.png does not exists so a warning is shown on Chrome Dev Tools when inspecting the PWA manifest
@CLAassistant

CLAassistant commented Oct 23, 2023

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@lastzero

Copy link
Copy Markdown
Member

Thank you very much! Must have been a typo...

@lastzero lastzero added the bug label Oct 23, 2023
@lastzero lastzero changed the title Fix PWA 77px logo icon size to 76px PWA: Fix app manifest logo icon sizes Oct 23, 2023
@lastzero lastzero added the merged Changes are merged, but may require further testing label Oct 23, 2023
@lastzero
lastzero merged commit 50d6d6d into photoprism:develop Oct 23, 2023
@lastzero lastzero added the please-test Ready for manual testing & feedback label Oct 23, 2023
@graciousgrey graciousgrey added tested Changes have been tested successfully released Available in a stable release and removed please-test Ready for manual testing & feedback labels Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged Changes are merged, but may require further testing released Available in a stable release tested Changes have been tested successfully

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants