New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional photo location unit tests #918
Additional photo location unit tests #918
Conversation
4528f67
to
e2720d3
Compare
Should use our source priority lookup table... See title and description. |
Let us know if these changes work for you :) |
Oh, I didnt see that you pushed a fix already. My solution is largely the same, but it allows to overwrite an existing photo location (if for example you correct the geo information for an image directly in the exif data). And there are few more unit tests as well. |
The location should be updated automatically after lat / lng have been changed. If this is not the case, that's a bug? Of course depending on the specific API / function you use for this. Make sure to also update the location source so that PhotoPrism knows this is a manual change. Otherwise, you may not be able to overwrite existing metadata. |
Thank you very much & sorry for the wait! 👍 |
I had a folder with non-geotagged photos, where the location was estimated based on the folder's name. After manually geo-tagging them, the location was not set after re-indexing the folder, becauseestimated
locations are not allowed to be overwritten, which was probably not intended.Add few additional unit tests to make sure the photo location is set correctly.