Fix custom basepath in React components #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #838 +/- ##
===========================================
- Coverage 65.53% 36.18% -29.36%
===========================================
Files 138 38 -100
Lines 12895 1708 -11187
Branches 533 0 -533
===========================================
- Hits 8451 618 -7833
+ Misses 4288 934 -3354
Partials 156 156
Flags with carried forward coverage won't be shown. Click here to find out more. see 100 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
truecharts-admin
added a commit
to truecharts/charts
that referenced
this pull request
Jun 24, 2024
…f914c44 by renovate (#23728) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [viktorstrate/photoview](https://togithub.com/photoview/photoview) | minor | `2.3.13` -> `2.4.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>photoview/photoview (viktorstrate/photoview)</summary> ### [`v2.4.0`](https://togithub.com/photoview/photoview/releases/tag/v2.4.0): Project restart: a lot of improvements! [Compare Source](https://togithub.com/photoview/photoview/compare/v2.3.13...v2.4.0) #### Summary This is the 1st release after project restart. It contains a lot of fixes, improvements, and even refactoring. We've included the most important changes, contributed by the Photoview Community while the project was on hold and during these few months after the restart. We hope that future releases won't take so much time and will contain smaller lists of changes ;-) ##### *IMPORTANT*: If you're using Docker deployment and didn't use the `master` branch + image with the new configs, make sure to carefully read the [Getting started — Setup with Docker](https://togithub.com/photoview/photoview?tab=readme-ov-file#getting-started--setup-with-docker) section of the Readme and apply the new config as described there! Simply pulling the new image won't work! #### What's Changed ##### Added - Add support for .CR3 photos by [@​PJ-Watson](https://togithub.com/PJ-Watson) in [photoview/photoview#728 - Add swipe gesture by [@​eadisor](https://togithub.com/eadisor) in [photoview/photoview#651 - Add globe view of Mapbox in Places page by [@​noel123007](https://togithub.com/noel123007) in [photoview/photoview#774 - Add the Turkish language by [@​queeup](https://togithub.com/queeup) in [photoview/photoview#780 - Add support to parse DateTimes with UTC+Offset by [@​yosev](https://togithub.com/yosev) in [photoview/photoview#802 - Add Ukrainian translation by [@​kkovaletp](https://togithub.com/kkovaletp) in [photoview/photoview#875 - Add cross-compile support for arm64 to amd64 by [@​cicadabear](https://togithub.com/cicadabear) in [photoview/photoview#888 - (docker-compose): add SQLite variable and volumes example by [@​alcaprar](https://togithub.com/alcaprar) in [photoview/photoview#851 ##### Improved - Thumbnail Rendering Options by [@​PJ-Watson](https://togithub.com/PJ-Watson) in [photoview/photoview#725 - Config🔧: Improved Simplified Chinese language translation by [@​rainpenber](https://togithub.com/rainpenber) in [photoview/photoview#749 - Restyle titles and spacing in the timeline gallery by [@​orellazri](https://togithub.com/orellazri) in [photoview/photoview#752 - Limit thumbnail size of the small original photo in the new branch by [@​WindLi001](https://togithub.com/WindLi001) in [photoview/photoview#798 - Updated Translation for German by [@​secco04](https://togithub.com/secco04) in [photoview/photoview#841 - Update German translation by [@​secco04](https://togithub.com/secco04) in [photoview/photoview#842 - Update Italian translation by [@​davidecavestro](https://togithub.com/davidecavestro) in [photoview/photoview#873 - Reordered CLI arguments for FFmpeg to improve speed to generate thumbnails of videos by [@​AndGem](https://togithub.com/AndGem) in [photoview/photoview#917 - Update Polish translation by [@​DorianMazur](https://togithub.com/DorianMazur) in [photoview/photoview#909 - Faster start of video playback by [@​kabakaev](https://togithub.com/kabakaev) in [photoview/photoview#883 - Don't stop scanning the album on media fail by [@​kkovaletp](https://togithub.com/kkovaletp) in [photoview/photoview#892 - Remove login page non-empty password requirement by [@​subtlepseudonym](https://togithub.com/subtlepseudonym) in [photoview/photoview#828 - Make face detection optional at build-time by [@​emersion](https://togithub.com/emersion) in [photoview/photoview#881 - Remove logging of database URL in place for just dialect by [@​jordy2254](https://togithub.com/jordy2254) in [photoview/photoview#940 - Refactor docker deployment and user setup by [@​kkovaletp](https://togithub.com/kkovaletp) in [photoview/photoview#863 - Allow SQLite to accept several connections at the same time by [@​kkovaletp](https://togithub.com/kkovaletp) in [photoview/photoview#955 ##### Fixed - Fix transaction already committed error by [@​Ajnasz](https://togithub.com/Ajnasz) in [photoview/photoview#795 - Fix translation error of Chinese UI in a new branch by [@​WindLi001](https://togithub.com/WindLi001) in [photoview/photoview#796 - Use Clean() but not Abs() to prevent directory traversal by [@​WindLi001](https://togithub.com/WindLi001) in [photoview/photoview#799 - Fix the "HEIC: failed to parse Exif data: exiftool buffer too small" issue by [@​tymmej](https://togithub.com/tymmej) in [photoview/photoview#807 - Fix encoding video thumbnails by [@​tymmej](https://togithub.com/tymmej) in [photoview/photoview#810 - Prepend missing key CreationDate to createDateKeys of FFmpeg parser by [@​yosev](https://togithub.com/yosev) in [photoview/photoview#822 - Fix custom basepath in React components by [@​djvaldez](https://togithub.com/djvaldez) in [photoview/photoview#838 - Fix build pipeline by [@​viktorstrate](https://togithub.com/viktorstrate) in [photoview/photoview#865 - Fix UI not serving media and tests expecting localhost:3000 as base URL by [@​davidecavestro](https://togithub.com/davidecavestro) in [photoview/photoview#874 - Fix invalid UTC offset during date-time parsing by [@​yosev](https://togithub.com/yosev) in [photoview/photoview#823 - Fix audit issues in production by [@​jordy2254](https://togithub.com/jordy2254) in [photoview/photoview#933 - Fix false trigger of DB migration on SQLite by [@​kabakaev](https://togithub.com/kabakaev) in [photoview/photoview#936 - Fix download path on custom base path by [@​djvaldez](https://togithub.com/djvaldez) in [photoview/photoview#889 - Dockerfile: Fail chained command in RUN if some of the commands fail by [@​kkovaletp](https://togithub.com/kkovaletp) in [photoview/photoview#947 - Fix timeline order with SQLite3. It should be ordered as MySQL and PGSQL like `(year, month, day)`. by [@​googollee](https://togithub.com/googollee) in [photoview/photoview#954 - Update the `healthcheck` command for the MariaDB container by [@​kkovaletp](https://togithub.com/kkovaletp) in [photoview/photoview#963 - Fix typo in the `serviceWorkerRegistration.ts` by [@​kkovaletp](https://togithub.com/kkovaletp) in [photoview/photoview#964 - Freezing UID and GID of the `photoview` user in the Dockerfile by [@​kkovaletp](https://togithub.com/kkovaletp) in [photoview/photoview#972 #### New Contributors - [@​eadisor](https://togithub.com/eadisor) made their first contribution in [photoview/photoview#651 - [@​rainpenber](https://togithub.com/rainpenber) made their first contribution in [photoview/photoview#749 - [@​noel123007](https://togithub.com/noel123007) made their first contribution in [photoview/photoview#774 - [@​queeup](https://togithub.com/queeup) made their first contribution in [photoview/photoview#780 - [@​Ajnasz](https://togithub.com/Ajnasz) made their first contribution in [photoview/photoview#795 - [@​WindLi001](https://togithub.com/WindLi001) made their first contribution in [photoview/photoview#796 - [@​yosev](https://togithub.com/yosev) made their first contribution in [photoview/photoview#802 - [@​tymmej](https://togithub.com/tymmej) made their first contribution in [photoview/photoview#807 - [@​djvaldez](https://togithub.com/djvaldez) made their first contribution in [photoview/photoview#838 - [@​secco04](https://togithub.com/secco04) made their first contribution in [photoview/photoview#841 - [@​davidecavestro](https://togithub.com/davidecavestro) made their first contribution in [photoview/photoview#873 - [@​kkovaletp](https://togithub.com/kkovaletp) made their first contribution in [photoview/photoview#875 - [@​AndGem](https://togithub.com/AndGem) made their first contribution in [photoview/photoview#917 - [@​cicadabear](https://togithub.com/cicadabear) made their first contribution in [photoview/photoview#888 - [@​DorianMazur](https://togithub.com/DorianMazur) made their first contribution in [photoview/photoview#909 - [@​alcaprar](https://togithub.com/alcaprar) made their first contribution in [photoview/photoview#851 - [@​kabakaev](https://togithub.com/kabakaev) made their first contribution in [photoview/photoview#883 - [@​subtlepseudonym](https://togithub.com/subtlepseudonym) made their first contribution in [photoview/photoview#828 - [@​emersion](https://togithub.com/emersion) made their first contribution in [photoview/photoview#881 - [@​jordy2254](https://togithub.com/jordy2254) made their first contribution in [photoview/photoview#933 - [@​googollee](https://togithub.com/googollee) made their first contribution in [photoview/photoview#954 **Full Changelog**: photoview/photoview@v2.3.13...v2.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTQuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQxNC4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInVwZGF0ZS9kb2NrZXIvZ2VuZXJhbC9ub24tbWFqb3IiXX0=-->
marvimarv
pushed a commit
to marvimarv/photoview
that referenced
this pull request
Jul 27, 2024
Fix custom basepath in React components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #834 that restores basic app functionality in case of building with
UI_PUBLIC_URL. Themanifest.jsonstill contains hardcoded relative URLs. The service worker also doesn't work with custom basepath.