Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace egg with sdist bdist_wheel in dist:python npm command #260

Merged
1 commit merged into from
Dec 3, 2019

Conversation

thinkh
Copy link
Contributor

@thinkh thinkh commented Dec 3, 2019

Closes #259

Developer Checklist (Definition of Done)

  • Descriptive title for this pull request provided (will be used for release notes later)
  • All acceptance criteria from the issue are met
  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Code documentation written
  • Unit tests written
  • Build is successful
  • Summary of changes written
  • Wiki documentation written
  • Assign at least one reviewer
  • Assign at least one assignee
  • Add type label (e.g., bug, enhancement) to this pull request
  • [x Add next version label (e.g., release: minor) to this PR following semver

Summary of changes

  • Replace egg with sdist bdist_wheel in dist:python npm command

@thinkh thinkh added type: technical-debt Describes or removes a technical debt release: major PR merge results in a new major version labels Dec 3, 2019
@thinkh thinkh requested a review from a user December 3, 2019 11:57
@thinkh thinkh assigned ghost Dec 3, 2019
@thinkh
Copy link
Contributor Author

thinkh commented Dec 3, 2019

@anita-steiner I'm not sure if this change results in a major or even a patch release... What do you think?

@ghost
Copy link

ghost commented Dec 3, 2019

@anita-steiner I'm not sure if this change results in a major or even a patch release... What do you think?
I think for the user of the generator it's a major release

@ghost ghost merged commit 0e0fb26 into develop Dec 3, 2019
@ghost ghost deleted the thinkh/259_replace-python-dist-egg-with-wheels branch December 3, 2019 13:38
@thinkh thinkh mentioned this pull request Dec 10, 2019
21 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: major PR merge results in a new major version type: technical-debt Describes or removes a technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant