Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use quotes for PHP version numbers in README #75

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

osma
Copy link
Contributor

@osma osma commented Jan 21, 2022

The PHP version numbers in the README did not use quotes. This is fine for e.g. 7.1, 7.2, 7.3 and 7.4 but not 8.0, which is interpreted as 8 by YAML and currently resolves to 8.1.1. See this comment by @ngrie for an explanation.

Fixes #73

(I suppose a similar fix should be made also for other php-actions modules which use the same mechanism, at least php-actions/phpunit)

@g105b
Copy link
Member

g105b commented Jan 25, 2022

Thank you @osma - I didn't know that was how YAML numbers worked. In fact, I find all YAML config confusing, so I'm glad you made this change as it will help a lot of future developers out.

Thanks again.

@g105b g105b merged commit ac8b2c0 into php-actions:master Jan 25, 2022
@osma
Copy link
Contributor Author

osma commented Jan 25, 2022

I find YAML confusing too, and I didn't know about the number parsing either until I found out the hard way - thanks again @ngrie for clarifying this!

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Getting php 8.1 instead of 8.0
2 participants