Set minimum PHP version to 5.6 #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramunasd
force-pushed
the
minimum_version_5_6
branch
from
5f4aad9
to
0a1ab5e
Compare
lukebakken
approved these changes
Jul 8, 2019
|
Thanks! |
|
We should release |
|
@lukebakken I would like to fix #706 and do some internal refactorings, which are already almost prepared for PR. |
|
No hurry at all! Thanks for your hard work. |
kratkyzobak
pushed a commit
to kratkyzobak/php-amqplib
that referenced
this pull request
Feb 9, 2024
Set minimum PHP version to 5.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old supported versions like 5.4 and 5.5 became unpopular and rarely used. According to packagist statistics[1] only 1.5% of all installs use PHP 5.5, 5.4 less than 1%. Meanwhile 5.5 and 5.6 has some very nice improvements and features like generators, finally keyword, support for constant array/string dereferencing and scalar class names via constant ::class.
[1] https://blog.packagist.com/php-versions-stats-2019-1-edition/
[2] https://www.php.net/releases/5_5_0.php
[3] https://www.php.net/releases/5_6_0.php