-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More support macOS #538
Comments
Thanks for getting in touch. We're absolutely open to contributions. Please let me know how you get on. :) |
Ah, I see this relates to php/php-src#3616. We probably want this patched at an earlier level than master. I guess they'll merge it where they want. Just, master branch is for PHP 7.4 I think. |
I implemented my idea on https://github.com/mizunashi-mana/php-build/tree/add-fallback-for-openssl. This provides only openssl fallback, so, we cannot build PHP with just this patch on Mojave. And, found a bug for https://github.com/madumlao/php-build/tree/osx-zlib: @madumlao We should specify the
@GrahamCampbell Yes, I think so. Actually, I'm waiting any reactions of PHP team and searching any better solutions. |
See also: phpenv/phpenv#90 (comment)
Now, on macOS, such command gets error:
https://github.com/rbenv/ruby-build and https://github.com/pyenv/pyenv/tree/master/plugins/python-build provides fallbacks to use homebrew bundled package or build method to use latest OpenSSL.
ruby-build/python-build's method:
I want this support for PHP. This support helps also phpenv/phpenv#77 .
@madumlao 's approach is similar. However, I think this is too expensive. In my cases, php-build should use macOS bundled zlib/bzip2 as possible.
I would like you to discuss this points and provide more supports for macOS users.
And I report test results of https://github.com/madumlao/php-build/tree/osx-zlib on this issue.
The text was updated successfully, but these errors were encountered: