Add fallback for openssl #545
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mizunashi-mana
force-pushed
the
add-fallback-for-openssl
branch
from
cd70061
to
d090018
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by https://github.com/rbenv/ruby-build
PHP with php-build configure options needs only external openssl and icu4c on XCode >= 9.1 (The latest is XCode 10.1). Now, php-build has detection codes for openssl and icu4c of Homebrew. But, openssl detection is not working.
I improve openssl detection and more add fallback when detection fails (installing and building openssl from source).
Notice: for maintanance costs, I add fallback to only PHP >= 7.2. In cases of php < 7.2, this patch only detect Homebrew packages.
See also: #538
Also includes:
P.S.
I expect anyone improve php-build codes to use new generation codes for maintanance.