Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "wipe" option from the Copy Build plugin doesn't work #207

Closed
jwmwalrus opened this issue Jul 30, 2018 · 4 comments
Closed

The "wipe" option from the Copy Build plugin doesn't work #207

jwmwalrus opened this issue Jul 30, 2018 · 4 comments

Comments

@jwmwalrus
Copy link
Contributor

jwmwalrus commented Jul 30, 2018

Hi.

When setting the complete.copy_build.wipe option to true, no wipe is performed before the build is copied.

It's certainly not a deal breaker, but storage can become an issue pretty quickly when using the Copy Build plugin.

Environment

  • PHP Censor version: 0.23.0-1-geef73d8e
  • Operating System: Debian GNU/Linux 9.5 (stretch)
  • PHP version: 7.2.7-1+0~20180622080745.23+stretch~1.gbpfd8e2e
  • MySQL/PostgreSQL version: 15.1 Distrib 10.1.26-MariaDB
@corpsee
Copy link
Member

corpsee commented Jul 30, 2018

@jwmwalrus Thanks.

@corpsee
Copy link
Member

corpsee commented Sep 2, 2018

@jwmwalrus Can you test the problem on local-build branch please? But you should know that I changed LocalBuild logic little bit.

@jwmwalrus
Copy link
Contributor Author

Hi.

I can confirm that when in the local-build branch, the contents of the target directory are removed when wipe: true is used (and the copied build is no longer in a subdirectory of the target directory).

@corpsee
Copy link
Member

corpsee commented Sep 4, 2018

Thank you! I merged local-build to master.

@corpsee corpsee closed this as completed Sep 4, 2018
@corpsee corpsee removed this from the Version 1.0.* (patch) milestone May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants