Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CopyBuild plugin does not copy hidden files #242

Closed
benr77 opened this issue Dec 21, 2018 · 3 comments
Closed

CopyBuild plugin does not copy hidden files #242

benr77 opened this issue Dec 21, 2018 · 3 comments

Comments

@benr77
Copy link
Member

benr77 commented Dec 21, 2018

Expected behavior

The CopyBuild plugin should copy all project files.

Actual behavior

The CopyBuild plugin does not copy hidden files.

For example, in my project root I have a .mage.yml config file for deployment, but if the CopyBuild plugin is used, it does not copy this file.

Steps to reproduce

Set up the CopyBuild plugin and run it on a project with a hidden file in the project root. See that the hidden file is then not copied to the destination folder.

It seems this is simply because the copy command uses a * wildcard which does not include hidden files.

$cmd = 'mkdir -p "%s" && cp -R %s/* "%s"';

The command could be duplicated to copy hidden files on a second execution. Alternatively, the following syntax should work to copy hidden and visible files in a single notation (replacing the * with . as noted here https://superuser.com/a/367303)

'mkdir -p "%s" && cp -R %s/. "%s"'

Environment

  • PHP Censor dev-master
  • Docker
  • PHP 7.2
  • MySQL
@corpsee
Copy link
Member

corpsee commented Dec 21, 2018

@benr77 Thanks! Very useful information about reasons. I will fix it.

@corpsee
Copy link
Member

corpsee commented Dec 22, 2018

@benr77 Fixed in master branch.

@corpsee corpsee closed this as completed Dec 22, 2018
@benr77
Copy link
Member Author

benr77 commented Dec 26, 2018

Confirmed fixed. Thanks for your efforts!

@corpsee corpsee removed this from the Version 1.0.* (patch) milestone May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants