SeriesInfoExtractorServiceImpl.extractMichelNumbers(): add unit test.

Fix #903
php-coder · Jul 16, 2018 · a65d23b · a65d23b
1 parent caefcdd
commit a65d23b
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/main/java/ru/mystamps/web/service/SeriesInfoExtractorServiceImpl.java b/src/main/java/ru/mystamps/web/service/SeriesInfoExtractorServiceImpl.java
@@ -267,7 +267,6 @@ protected Boolean extractPerforated(String fragment) {
 		return null;
 	}
 
-	// @todo #694 SeriesInfoExtractorServiceImpl.extractMichelNumbers(): add unit tests
 	// @todo #694 SeriesInfoExtractorServiceImpl: support for a single Michel number
 	// @todo #694 SeriesInfoExtractorServiceImpl: support for a comma separated Michel numbers
 	protected Set<String> extractMichelNumbers(String fragment) {

diff --git a/src/test/groovy/ru/mystamps/web/service/SeriesInfoExtractorServiceImplTest.groovy b/src/test/groovy/ru/mystamps/web/service/SeriesInfoExtractorServiceImplTest.groovy
@@ -377,6 +377,23 @@ class SeriesInfoExtractorServiceImplTest extends Specification {
 			'БЕЗЗУБЦОВЫЕ' | _
 	}
 
+	//
+	// Tests for extractMichelNumbers()
+	//
+
+	@Unroll
+	def 'extractMichelNumbers() should extract "#expected" from "#fragment"'(String fragment, Set<String> expected) {
+		expect:
+			service.extractMichelNumbers(fragment) == expected
+		where:
+			fragment      || expected
+			nullOrBlank() || []
+			'# 1-3'       || [ '1', '2', '3' ]
+			'#9997-9999'  || [ '9997', '9998', '9999' ]
+			'#9999-9997'  || []
+			'#0997-0999'  || []
+	}
+
 	//
 	// Tests for extractSeller()
 	//