Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Series sale import: use its own interface and form #1026

Closed
0pdd opened this issue Jun 3, 2019 · 0 comments
Closed

Series sale import: use its own interface and form #1026

0pdd opened this issue Jun 3, 2019 · 0 comments
Assignees
@php-coder
Labels
refactoring techdebt trivial
Milestone
0.4.1

Comments

@0pdd
Copy link

0pdd commented Jun 3, 2019 •
edited by php-coder

The puzzle 995-f1c8f888 from #995 has to be resolved:

mystamps/src/main/java/ru/mystamps/web/feature/series/importing/RequestImportForm.java

Line 41 in bc3fe55

// @todo #995 Series sale import: use its own interface and form

The puzzle was created by Slava Semushin on 03-Jun-19.
@0pdd 0pdd added the techdebt label Jun 3, 2019
0pdd referenced this issue Jun 3, 2019
@php-coder
feat: implement import of a series sales by URL.
bc3fe55 
Implementation details:
- /series/{id}: a new form for importing a series sale has been added.
  It's only available when ADD_PURCHASES_AND_SALES Togglz feature is
  active and user has IMPORT_SERIES_SALES authority
- IMPORT_SERIES_SALES authority has been added and granted to admin user
  by default
- migration: JacksonAutoConfiguration should be removed from
  spring.autoconfigure.exclude property in application*.properties file

Fix #995
@0pdd 0pdd mentioned this issue Jun 3, 2019
Closed
@php-coder php-coder added this to the 0.4.1 milestone Jun 3, 2019
@php-coder php-coder self-assigned this Jul 14, 2019
php-coder added a commit that referenced this issue Jul 21, 2019
@php-coder
refactor: rename RequestImportForm to RequestSeriesImportForm.
ab45d0a 
Addressed to #1026
php-coder added a commit that referenced this issue Jul 21, 2019
@php-coder
chore: update a backing object name to fix integration tests.
74c4c78 
Correction for ab45d0a commit.

Regression after #1026
annazarubina pushed a commit to annazarubina/mystamps that referenced this issue Jul 23, 2019
@php-coder @annazarubina
refactor: rename RequestImportForm to RequestSeriesImportForm.
95652fd 
Addressed to php-coder#1026
annazarubina pushed a commit to annazarubina/mystamps that referenced this issue Jul 23, 2019
@php-coder @annazarubina
refactor: use a separate class for a form for requesting an import of…
10b4311 
… a sale of a series.

Fix php-coder#1026
annazarubina pushed a commit to annazarubina/mystamps that referenced this issue Jul 23, 2019
@php-coder @annazarubina
chore: update a backing object name to fix integration tests.
4eb0a07 
Correction for ab45d0a commit.

Regression after php-coder#1026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
refactoring techdebt trivial
Projects
None yet
Milestone
0.4.1
Development

No branches or pull requests
2 participants
@php-coder @0pdd