Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SeriesImportController.showRequestAndImportSeriesForm(): extract a method for adding shared attributes to the model #717

Closed
0pdd opened this issue Dec 1, 2017 · 0 comments
Closed

SeriesImportController.showRequestAndImportSeriesForm(): extract a method for adding shared attributes to the model #717

0pdd opened this issue Dec 1, 2017 · 0 comments
Assignees
@php-coder
Labels
refactoring techdebt
Milestone
0.4

Comments

@0pdd
Copy link

0pdd commented Dec 1, 2017 •
edited by php-coder

The puzzle 709-699a0113 (from #709) in src/main/java/ru/mystamps/web/controller/SeriesImportController.java (lines 145-146) has to be resolved: "SeriesImportController.showRequestAndImportSeriesForm(): extract a method for adding shared attributes to the model"

The puzzle was created by Slava Semushin on 24-Nov-17.

Tech debt for: 97e27e3 (#709)
0pdd referenced this issue Dec 1, 2017
@php-coder
Import series: redesign an import process to not use series creation …
97e27e3 
…page.

Fix #709
@php-coder php-coder changed the title SeriesImportController.java:145-146: ... SeriesImportController.showRequestAndImportSeriesForm(): extract a method for adding shared attributes to the model Dec 2, 2017
@php-coder php-coder added this to the 0.4 milestone Dec 2, 2017
@php-coder php-coder self-assigned this Dec 2, 2017
php-coder added a commit that referenced this issue Dec 2, 2017
@php-coder
SeriesController: extract duplicated code to separate methods.
aa3fb57 
Related to #717

No functional changes.
php-coder added a commit that referenced this issue Dec 2, 2017
@php-coder
SeriesController.YEARS: make it private again.
80d4994 
Should be in 38b85cb commit.

Addressed to #717

No functional changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
refactoring techdebt
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
2 participants
@php-coder @0pdd