Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CollectionService.addToCollection(): introduce DTO object #880

Closed
0pdd opened this issue Jun 13, 2018 · 2 comments
Closed

CollectionService.addToCollection(): introduce DTO object #880

0pdd opened this issue Jun 13, 2018 · 2 comments
Assignees
@php-coder
Labels
refactoring techdebt
Milestone
0.4

Comments

@0pdd
Copy link

0pdd commented Jun 13, 2018

The puzzle 477-070e66a6 from #477 has to be resolved:

mystamps/src/main/java/ru/mystamps/web/service/CollectionServiceImpl.java

Line 69 in 4cb3692

// @todo #477 CollectionService.addToCollection(): introduce DTO object

The puzzle was created by Slava Semushin on 13-Jun-18.

Estimate: 0 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd 0pdd added the techdebt label Jun 13, 2018
0pdd referenced this issue Jun 13, 2018
@php-coder
User may specify how many stamps from a series he has in collection.
4cb3692 
Fix #477
@0pdd 0pdd mentioned this issue Jun 13, 2018
Closed
@php-coder php-coder self-assigned this Jun 14, 2018
@php-coder php-coder added this to the 0.4 milestone Jun 14, 2018
@0pdd 0pdd mentioned this issue Jun 14, 2018
Closed
@0pdd
Copy link
Author

0pdd commented Jun 14, 2018

@0pdd the puzzle #882 is still not solved.

php-coder added a commit that referenced this issue Jun 14, 2018
@php-coder
JdbcCollectionDao.addSeriesToUserCollection(): introduce DTO object.
487914e 
Fix #880
@0pdd
Copy link
Author

0pdd commented Jun 14, 2018

@0pdd the only puzzle #882 is solved here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
refactoring techdebt
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
2 participants
@php-coder @0pdd