GH Actions/CI: run the test suite against PHP 8.1, 8.2 and 8.3 #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests were failing on PHP 8.1 due to a `file_exists(): Passing null to parameter php-coveralls#1 ($filename) of type string is deprecated` notice coming from the `JobsRepository::dumpJsonFile()` method. While it would probably be unlikely for this error condition ever to be hit in a real life situation, it is something which is likely to happen in the tests and well, a little defensive coding goes a long way. With this fix in place, the tests now pass on PHP 8.1 and PHP 8.2 and compatibility with both can be declared. 🎉
PR 361 should fix the remaining (known) PHP 8.1 error. Once that PR has been merged, the CI runs against PHP 8.1, 8.2 and 8.3 should pass. To that end, I'm adding builds against PHP 8.1, 8.2 and 8.3. I'm also moving the code coverage recording from PHP 7.4 to PHP 8.2 to ensure high/low PHP is measured and adding an extra variant with `Xdebug` on high PHP too. As PHP 8.3 is still in flux, builds against it are still allowed to fail.
|
@keradus Anything I can do to move this PR forward ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #361 should fix the remaining (known) PHP 8.1 error.
Once that PR has been merged, the CI runs against PHP 8.1, 8.2 and 8.3 should pass.
To that end, I'm adding builds against PHP 8.1, 8.2 and 8.3.
I'm also moving the code coverage recording from PHP 7.4 to PHP 8.2 to ensure high/low PHP is measured and adding an extra variant with
Xdebugon high PHP too.As PHP 8.3 is still in flux, builds against it are still allowed to fail.