Hotfix for 1.2 #56
Merged
Hotfix for 1.2 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fanlei
commented
Nov 3, 2019
fanlei
commented
- Fix the magic method name for unset()
- Remove const MIN_CAPACITY assignment in Queue
- Assign the current stamp to the instance copy
- Fix documentation content.
Remain the current value of property stamp to gurantee the new instance copy with "First in, first out" ordering been preserved for values with the same priority.
It's not necessary to assign the const MIN_CAPACITY again since MIN_CAPACITY has been already handled in the Deque composited.
rtheunissen
reviewed
Nov 4, 2019
src/Hashable.php
Outdated
| @@ -26,7 +26,7 @@ function hash(); | |||
| * Determines if two objects should be considered equal. Both objects will | |||
| * be instances of the same class but may not be the same instance. | |||
| * | |||
| * @param $obj An instance of the same class to compare to. | |||
| * @param $obj - An instance of the same class to compare to. | |||
There was a problem hiding this comment.
There is no type after @param so IDE such as Eclipse PDT would raise a syntax error in the doc block. However, I confess I was not sure what type to put there at the time when I was trying to fix it.
I checked further now and supposed $obj could be everything, according to php-ds/ext-ds#140. Do you think it's better to be 'mixed' there instead?
rtheunissen
requested changes
Nov 4, 2019
|
Thank you for reviewing. Yes, I should keep it consistent. |
|
The tests and versioning is a bit of a mess it seems - haven't looked at this in a while. I'd like to consolidate all the components as part of a 1.3.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.