-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for orders & invoice #8
Conversation
viezel
commented
Mar 21, 2019
- Add support for orders & invoice
- phpunit and unit tests
@sabas ready for review |
Quick suggestions:
|
@davidvandertuijn sure ill change the reference. |
Thank you @viezel, I'll try to merge this night.. Just to ask also to @davidvandertuijn I pulled the changes in my client code some days ago and I noticed it failed with a type error when providing arrays with ints as it was annotated with string in the parameters, so I changed the default values from null to the previous value as string (15th march commit) Do you want access to the repository or to the org? |
Sure @sabas That would be neat to gain access. Then I could setup travis to automatically run tests for this |
@sabas thanks for merging it in. |
@viezel done please try |