Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/csv #2

Merged
merged 29 commits into from
May 1, 2021
Merged

Feature/csv #2

merged 29 commits into from
May 1, 2021

Conversation

sebprt
Copy link
Contributor

@sebprt sebprt commented Mar 24, 2021 •
edited
Loading

No description provided.

@sebprt sebprt added the WIP Work in Progress label Mar 24, 2021
@sebprt sebprt requested a review from gplanchat March 24, 2021 16:20
@sebprt sebprt self-assigned this Mar 24, 2021
@sebprt sebprt added GTM Good to merge and removed WIP Work in Progress labels Mar 31, 2021
@sebprt sebprt requested review from clemzarch, programgames and XaBe20 and removed request for XaBe20 March 31, 2021 07:19
gplanchat
gplanchat requested changes Apr 2, 2021
View reviewed changes
src/Configuration/Extractor.php Outdated Show resolved Hide resolved
src/Configuration/Loader.php Outdated Show resolved Hide resolved
src/Factory/Extractor.php Outdated Show resolved Hide resolved
src/Factory/Repository/Extractor.php Outdated Show resolved Hide resolved
src/Factory/Repository/Loader.php Outdated Show resolved Hide resolved
camilleislasse
camilleislasse reviewed Apr 7, 2021
View reviewed changes
Copy link

@camilleislasse camilleislasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2021-04-07_09-17

composer.json Outdated Show resolved Hide resolved
sebprt and others added 18 commits May 1, 2021 18:58
@sebprt @gplanchat
added missing files and updated logger option
69412e7
@sebprt @gplanchat
added name to params in constructor
53a63db
@sebprt @gplanchat
fixed named params in constructor
195a323
@sebprt @gplanchat
Updated tests: removed useless function and changed file path
fc43c5b
@sebprt @gplanchat
added final and declare() into classes
c56f343
@sebprt @gplanchat
added builders for csv, updated phpunit action, updated test and adde…
cf7dcfe 
…d readme
@sebprt @gplanchat
updated csv builders to use a static method
32650f1
@sebprt @gplanchat
updated tests with new assert names and added missing files, added te…
73c4e59 
…sts for CSV
@sebprt @gplanchat
Update README.md
0651d89
@sebprt @gplanchat
updated github actions (phpunit, phpstan), and fixed code with phpstan
796b777
@sebprt @gplanchat
updated phpunit action
e5f0401
@sebprt @gplanchat
updated dependencies, changed php code return by the builders to use …
4b80586 
…reader and writer setters
@sebprt @gplanchat
changed mistake in documentation
dcba6a1
@sebprt @gplanchat
add missing final and strict_type
f2acb84
@sebprt @gplanchat
change skip_line parameter to skip_lines, add final word to classes, …
82b590c 
…changed config tree validation
@sebprt @gplanchat
updated configuration validation (exclusive fields)
7295930
@sebprt @gplanchat
test change github action config
93f50fc
@sebprt @gplanchat
cancelled test for github action
07ac0cd
@gplanchat gplanchat merged commit 3ca579c into master May 1, 2021
@gplanchat gplanchat deleted the feature/csv branch May 1, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gplanchat gplanchat gplanchat approved these changes

@programgames programgames programgames approved these changes

@clemzarch clemzarch clemzarch approved these changes

@camilleislasse camilleislasse camilleislasse approved these changes

Assignees

@sebprt sebprt

Labels
GTM Good to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sebprt @gplanchat @programgames @clemzarch @camilleislasse