Update PSR-16 example code to latest version #1313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayw-geek
changed the title
samdark
approved these changes
Jan 4, 2024
garak
approved these changes
Jan 4, 2024
Crell
requested changes
Jan 4, 2024
I see. So your suggestion is that the sample code doesn't need to be changed at all? Aside from that, the sample code has changes in the extends class and modifications to the comments. I think it's not a bad thing to let more people see the latest and correct sample code. |
|
It's not sample code. It's the spec. The spec doesn't change. The interface packages are tweaked to move the already-defined type rules into the source. That just needs a mention in the metadoc, which... I think already happened for PSR-16, didn't it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updated the example code as the
psr/simple-cachepackage upgraded