Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Correct Github with GitHub (with capital H) as it is a brand name #1323

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

DannyvdSluijs
Copy link
Contributor

@DannyvdSluijs DannyvdSluijs commented Apr 29, 2024

GitHub is the correct spelling (with a capital H) of the brand that is being referred to.

One (of many) examples is the GitHub Terms of Service

@DannyvdSluijs DannyvdSluijs requested a review from a team as a code owner April 29, 2024 19:51
@DannyvdSluijs DannyvdSluijs requested a review from a team as a code owner April 29, 2024 19:54
Copy link
Contributor

@Crell Crell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this needs a vote, since it's just a spelling fix, but we should give the CC a chance to disagree.

Copy link
Member

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @Crell, I would consider this a typo fix.

@MrSuddenJoy
Copy link

Agreed. This is much needed.

Copy link

@MrSuddenJoy MrSuddenJoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jean85 Jean85 merged commit f833025 into php-fig:master Jun 5, 2024
@DannyvdSluijs DannyvdSluijs deleted the Correct-GitHub-brand-name branch June 5, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
8 participants