[PSR-7] "integer" is not a valid scalar type #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
simensen
added a commit
that referenced
this pull request
Apr 6, 2015
[PSR-7] "integer" is not a valid scalar type
|
@weierophinney Are you manually synchronizing the package yourself? |
|
@simensen - yes. Periodically updating the http - message repo and/or creating PR pairs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has always been the case that integer and boolean are aliases of int and bool, despite people's resistance to this (blame java, whatever), but as of php 7.0, integer really isn't allowed. PHP's implementation of scalar type hinting only allows you to use
int, notinteger. I think we should respect this and comply with PHP's official scalar types.// cc @ircmaxell