s/move/moveTo/ #539
Merged
s/move/moveTo/ #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per @Crell, this change clarifies the purpose of the method by renaming it to `moveTo()`. Additionally, the method argument name was changed to `$targetPath` to make the change completely clear.
|
$targetPath is even better, yes! One other question: What is that path relative to? I would implicitly assume it's script-root-relative, as is PHP's default, but that's not clear. (And script-root-relative is always messy anyway.) |
|
@Crell —
That would be dependent on the |
|
That should be made explicit, I think. Even if it's explicit to "the same logic as what PHP's move() function does" (which I think is the point). |
Per @Crell, explicit wording of how $targetPath should be resolved.
|
+1! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @Crell, this change clarifies the purpose of the method by renaming it to
moveTo(). Additionally, the method argument name was changed to$targetPathto make the change completely clear.