Fix grammatical issues in accepted proposals #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -108,7 +108,7 @@ if (! function_exists('bar')) { | |||
|
|
|||
| Namespaces and classes MUST follow an "autoloading" PSR: [[PSR-0], [PSR-4]]. | |||
|
|
|||
| This means each class is in a file by itself, and is in a namespace of at | |||
| This means each class is in a file by itself and is in a namespace of at | |||
There was a problem hiding this comment.
I wouldn't call this one incorrect as much as a stylistic difference.
|
Other than those noted above this seems fine to me. Thanks! |
|
Thanks for the feedback @Crell! I've reverted those three changes, squashed, and force-pushed. |
|
For my part, the edits to PSR-4 are acceptable. @Seldaek @weierophinney may wish to review the edits to their work as well. |
|
Looks good to me, thanks for the ping.
|
|
I'll merge this once I've had some form of a-okay from one of the PSR-7 team. |
|
👍 from me! |
|
Sorry for the delay, I missed Matthew's reply |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the issues are minor (excessive or missing commas) while others are slightly more glaring (incorrect tense, wrong preposition, missing/extra words, singular vs. plural, etc.)