New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add evolvable interfaces #788
Conversation
@@ -99,6 +99,24 @@ tool. Some hypermedia formats support templated links while others do not, and | |||
have a special way to denote that a link is a template. A Serializer for a format | |||
that does not support URI Templates MUST ignore any templated Links it encounters. | |||
|
|||
## 1.5 Evolvable collections | |||
|
|||
In some cases, a Link Collection may need the ability to hbave additional links |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/hbave/have/
/** | ||
* Returns an instance with the specified relationship included. | ||
* | ||
* If the specified rel is already present, this methid MUST return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/methid/method/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Fixed.
Rename PSR-13 interfaces to not be http specific
* The value of the attribute to set. | ||
* @return static | ||
*/ | ||
public function withAttribute($attribute, $value); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we also have a withoutAttribute($attribute)
method? (Considering we have a withoutRel()
method...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh. I could have sworn I added one. Will add.
👍 to providing |
As discussed on list, add optional interfaces for "evolvable" (with-able) objects, a la PSR-7. These are optional by design.