Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add evolvable interfaces #788

Merged
merged 10 commits into from Aug 5, 2016
Merged

Conversation

Crell
Copy link
Contributor

@Crell Crell commented Aug 1, 2016

As discussed on list, add optional interfaces for "evolvable" (with-able) objects, a la PSR-7. These are optional by design.

@@ -99,6 +99,24 @@ tool. Some hypermedia formats support templated links while others do not, and
have a special way to denote that a link is a template. A Serializer for a format
that does not support URI Templates MUST ignore any templated Links it encounters.

## 1.5 Evolvable collections

In some cases, a Link Collection may need the ability to hbave additional links
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/hbave/have/

/**
* Returns an instance with the specified relationship included.
*
* If the specified rel is already present, this methid MUST return

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/methid/method/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Fixed.

* The value of the attribute to set.
* @return static
*/
public function withAttribute($attribute, $value);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also have a withoutAttribute($attribute) method? (Considering we have a withoutRel() method...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh. I could have sworn I added one. Will add.

@michaelcullum
Copy link
Member

👍 to providing without... methods for consistency.

@weierophinney weierophinney merged commit 8692db7 into php-fig:master Aug 5, 2016
weierophinney added a commit that referenced this pull request Aug 5, 2016
weierophinney added a commit that referenced this pull request Aug 5, 2016
@Crell Crell deleted the link-evolvable branch August 14, 2016 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants