Sync with php-fig/http-message#50 #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
This now has conflicts, sorry @weierophinney |
This patch updates PSR-7 to always use `@return static` instead of `@return self` within method annotations, as done in php-fig/http-message#50. Per the discussion on that issue, `static` is interpreted by phpDoc and most IDEs in such a way that it always resolves to the class against which it was invoked, and not the defining class, unlike `self`, which always resolves to the class in which it was originally defined. Additionally, `static` has the *connotation* that a new instance, not the same instance, will be returned — which is the intention as outlined already in each method providing such a return value.
weierophinney
force-pushed
the
hotfix/http-message-50
branch
from
f85e9f7
to
2b845a6
Compare
|
@michaelcullum I've rebased and re-pushed now. |
|
Thanks. I'll merge this and the other tomorrow pending no objections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates PSR-7 to always use
@return staticinstead of@return selfwithin method annotations, as done in php-fig/http-message#50. Per the discussion on that issue,staticis interpreted by phpDoc and most IDEs in such a way that it always resolves to the class against which it was invoked, and not the defining class, unlikeself, which always resolves to the class in which it was originally defined. Additionally,statichas the connotation that a new instance, not the same instance, will be returned — which is the intention as outlined already in each method providing such a return value.