Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP return code 418 #3

Merged
merged 1 commit into from Feb 6, 2017
Merged

Add HTTP return code 418 #3

merged 1 commit into from Feb 6, 2017

Conversation

RinkAttendant6
Copy link
Contributor

Resolves #2.

@weierophinney weierophinney merged commit 1eec95f into php-fig:master Feb 6, 2017
weierophinney added a commit that referenced this pull request Feb 6, 2017
weierophinney added a commit that referenced this pull request Feb 6, 2017
weierophinney added a commit that referenced this pull request Feb 6, 2017
@weierophinney
Copy link
Contributor

Thanks, @RinkAttendant6! Released with version 1.1.1.

@RinkAttendant6 RinkAttendant6 deleted the http-418 branch February 6, 2017 19:25
@martinmine
Copy link

martinmine commented Aug 11, 2017

Note that the spec @RinkAttendant6 commits is actually an aprils fools. Note the date https://tools.ietf.org/html/rfc2518 also, it quotes: "This memo provides information for the Internet community. It does not specify an Internet standard of any kind.". HTTP 418 is according to IANA unassigned: https://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml

@RinkAttendant6
Copy link
Contributor Author

Regarding #3 (comment)

It might be a joke by the IETF, but there are certainly sites that implement it. Besides, I doubt that a future RFC would use the status code, and if there are, another change to this library would be warranted.

@martinmine
Copy link

@RinkAttendant6 where is my HTTP BREW then? :(

@RinkAttendant6
Copy link
Contributor Author

@martinmine There's four servers that advertise support for the BREW method in their Access-Control-Allow-Method response header: https://www.shodan.io/search?query=BREW+http+access-control-allow-methods

@martinmine
Copy link

@RinkAttendant6 thnx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants