avoid confusion about request #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
commented
Sep 16, 2016
| You can replace it and pass a new version downstream if you need. | ||
|
|
||
| .. note:: | ||
|
|
||
| Be aware that the request is immutable. |
There was a problem hiding this comment.
i found this mostly confusing. i can't tell what we wanted to say with this. we say that you can replace the request for a new version that you pass downstream. what else is there to say? the note made me wonder if the request would not be allowed to be changed.
There was a problem hiding this comment.
I guess it is just a gental reminder that you can to:
$request->withAddedHeader('Foo', 'Bar');Im okey with removing it.
|
@php-http/owners ok if we merge this? |
|
Im okey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.