-
Notifications
You must be signed in to change notification settings - Fork 56
Feature/plugins doc #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
plugins/content-length.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This plugin is useful when you want....
👍 I would recommend waiting for some input from @dbu as well, he usually has good points about docs (as well 😛 ) |
plugins/content-length.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ContentLenghtPlugin
sets the correct Content-Length
header value based on the size of the body stream of the request. This helps HTTP servers to handle the request.
thanks a lot for the work, joel! i added some feedback. update as much as you feel like, then lets merge. i can also do a follow up PR with further tweaks if you don't want to adress all of it, better have some documentation than none at all. |
Will try to implement all remarks by the end of the week. Wanted to add the other plugins also, but will do that in another PR |
plugins/content-length.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in .rst, you need double backticks for code, single backticks won't work. (needs to be fixed in all places, won't repeat it everywhere ,-) )
plugins/history.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This plugin collects data only after the request resolution. For logging purposes, ...
plugins/decoder.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with php-http/plugins#45 this is now ['use_content_encoding' => false]
Some last review ? |
plugins/cookie.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
‘store cookies’ (no ‘information’)
@joelwurtz Good job! Can you please wrap at 80 chars? That’s what we’re doing elsewhere in the docs as well (and is according to PHP coding standards, so easy to remember). |
Should be ready to merge |
Please squash. 😉 |
66a937c
to
c5b2795
Compare
I squash with one commit per documentation file |
Thanks, Joel! 😄 |
Build seems to have failed on readthedocs any idea ? |
Restarted the build, it was an API error |
Feature/plugins doc
No description provided.