Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update memcached.ini for php7 branch/pending release to reflect new ini settings and defaults. #233

Closed
TysonAndre opened this issue Mar 20, 2016 · 2 comments
Closed

Update memcached.ini for php7 branch/pending release to reflect new ini settings and defaults. #233

TysonAndre opened this issue Mar 20, 2016 · 2 comments

Comments

@TysonAndre
Copy link
Contributor

The ini entries in the documentation don't reflect the ini settings or code used in php_memcached.c.
Some options were renamed (E.g. sess_binary was renamed to sess_binary_protocol), some options had their defaults changed, and new options were added.

Before an official release is created for php7, this should be changed. Having up to date documentation also helps contributors and testers.
TysonAndre added a commit to TysonAndre/php-memcached that referenced this issue Mar 20, 2016
@TysonAndre
Document memcached.sess_binary_protocol
abc5be5 
And remove a TODO found in the code for allowing users to configure
whether or not to use binary protocols for sessions.

For issue php-memcached-dev#233
TysonAndre added a commit to TysonAndre/php-memcached that referenced this issue Mar 20, 2016
@TysonAndre
Document memcached.sess_binary_protocol
64a115d 
And remove a TODO found in the code for allowing users to configure
whether or not to use binary protocols for sessions.

For issue php-memcached-dev#233
@TysonAndre TysonAndre mentioned this issue Mar 20, 2016
Merged
TysonAndre added a commit to TysonAndre/php-memcached that referenced this issue Mar 20, 2016
@TysonAndre
Document ini settings for the default memcached connection configurat…
4bb264e 
…ions

This documents memcached.default_consistent_hash, default_binary_protocol, and
default_connect_timeout.

For issue php-memcached-dev#233
@TysonAndre TysonAndre mentioned this issue Mar 20, 2016
Merged
TysonAndre added a commit to TysonAndre/php-memcached that referenced this issue Mar 20, 2016
@TysonAndre
Document miscellaneous ini settings and new defaults for PHP7 release
61bb057 
This updates some of the memcached.ini documentation settings
to reflect the default ini settings used in php_memcached.c.
Some new settings were added, and other settings had changes to their defaults.

There are other new/updated settings, which can be changed in other PRs.

For issue php-memcached-dev#233
TysonAndre added a commit to TysonAndre/php-memcached that referenced this issue Mar 20, 2016
@TysonAndre
Document miscellaneous ini settings and new defaults for PHP7 release
e755d9d 
This updates some of the memcached.ini documentation settings
to reflect the default ini settings used in php_memcached.c.
Some new settings were added, and other settings had changes to their defaults.

There are other new/updated settings, which can be changed in other PRs.

For issue php-memcached-dev#233
@TysonAndre TysonAndre mentioned this issue Mar 20, 2016
Merged
TysonAndre added a commit to TysonAndre/php-memcached that referenced this issue Mar 22, 2016
@TysonAndre
Document memcached.sess_binary_protocol
fbdc4bb 
And remove a TODO found in the code for allowing users to configure
whether or not to use binary protocols for sessions.

For issue php-memcached-dev#233
TysonAndre added a commit to TysonAndre/php-memcached that referenced this issue Jul 25, 2016
@TysonAndre
Document memcached.sess_binary_protocol
045ab84 
And remove a TODO found in the code for allowing users to configure
whether or not to use binary protocols for sessions.

For issue php-memcached-dev#233
@sodabrew
Copy link
Contributor

sodabrew commented Aug 8, 2016

Thanks for the many doc updates so far! Would you give the php7 branch another once-over to see if any items remain before closing this issue?

@TysonAndre
Copy link
Contributor Author

It seems fine - the binary session serializer was the only issue I had. scanning php_memcached.c and memcached.ini again, they seem consistent.

I'd suggest documenting the change to session protocol setting and defaults in the Changelog when putting together release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sodabrew @TysonAndre