Fix: resolve strict NOTICE when userland extends and overrides get() et al #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What sort of signature do you inherit with? |
|
Ok, I can see the problem. 2 means ZEND_SEND_PREFER_REF in this case. This was changed during the time when user flags was added. Let me fire a debugger and try to figure out what's going on. I cannot merge this PR as it seems to be breaking three tests. |
|
Following PHP bug is related to this issue: https://bugs.php.net/bug.php?id=66331 |
|
I am going to change this into issue rather than pull request. No clear fix yet. |
|
See #126 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v2.2.0b1, any user-land class extending Memcached, and then overriding methods such as get(), would receive this strict NOTICE from PHP:
I've traced this to a few cases where the first param to ZEND_ARG_INFO was '2'. Changing these to '1' fixes this PHP strict NOTICE.