Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use mb_convert_encoding if it's available #137

Closed
wants to merge 4 commits into from
Closed

[WIP] Use mb_convert_encoding if it's available #137

wants to merge 4 commits into from

Conversation

takuseno
Copy link

@takuseno takuseno commented Feb 14, 2017

This is the PR copied from here.

Make Charset use mb_convert_encoding if the function is available.

This motivation comes from the issue that iconv is not working correctly on Alpine Linux.

https://bugs.alpinelinux.org/issues/5025

@takuseno takuseno changed the title Use mb_convert_encoding if it's available [WIP] Use mb_convert_encoding if it's available Feb 14, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 96.979% when pulling 5c6888c on takuseno:master into 9e98fd1 on php-mime-mail-parser:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 96.979% when pulling 5c6888c on takuseno:master into 9e98fd1 on php-mime-mail-parser:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 96.979% when pulling 0fd22f3 on takuseno:master into 9e98fd1 on php-mime-mail-parser:master.

@coveralls
Copy link

coveralls commented Feb 14, 2017

Coverage Status

Coverage decreased (-0.3%) to 96.979% when pulling 0fd22f3 on takuseno:master into 9e98fd1 on php-mime-mail-parser:master.

@eXorus
Copy link
Member

eXorus commented Feb 21, 2017

@takuseno Hello, thanks for your contribution. It is always work in progress ?

@takuseno
Copy link
Author

takuseno commented Feb 22, 2017

@eXorus
Hi, sorry that it's still in progress. I'm trying to disable mb_convert_encoding by runkit.

@eXorus
Copy link
Member

eXorus commented Mar 30, 2017

@takuseno Hello, any news about this ? are you still in progress ? it will be great to have it :)

@takuseno
Copy link
Author

@eXorus
Sorry for replying late. I didn't have enough time to make testings. Probably we have to use runkit or apd to disable mb_convert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants